Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ARR PC Console Filter/Email Changes #2502

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions openreview/arr/webfield/programChairsWebfield.js
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,22 @@ return {
return hasReply;
})
return checklistReplies?.length??0;
`,
deskRejectVerificationCount: `
const invitationToCheck="Desk_Reject_Verification";
const verificationReplies = row.note?.details?.replies.filter(reply => {
const hasReply = reply.invitations.some(invitation => invitation.includes(invitationToCheck));
return hasReply;
})
return verificationReplies?.length??0;
`,
metaReviewCount: `
const invitationToCheck="Meta_Review";
const metaReviewReplies = row.note?.details?.replies.filter(reply => {
const hasReply = reply.invitations.some(invitation => invitation.includes(invitationToCheck));
return hasReply;
})
return metaReviewReplies?.length??0;
`
},
reviewerEmailFuncs: [
Expand Down Expand Up @@ -226,6 +242,21 @@ return {
}
],
acEmailFuncs: [
{
label: 'ACs with any submitted meta-review', filterFunc: `
if (row.notes.length <= 0){
return false;
}

return row.notes.some(obj => {
return (obj?.note?.details?.replies ?? []).some(reply => {
return (reply?.invitations ?? []).some(inv => {
return inv.includes('Meta_Review')
})
})
})
`
},
{
label: 'ACs with assigned checklists, not all completed', filterFunc: `
if (row.notes.length <= 0){
Expand Down
4 changes: 4 additions & 0 deletions tests/test_arr_venue_v2.py
Original file line number Diff line number Diff line change
Expand Up @@ -5449,6 +5449,10 @@ def users_with_message(email_option, members):
send_email('Available ACs with No Assignments', 'area_chair')
assert users_with_message('Available ACs with No Assignments', area_chairs) == {'~AC_ARRFive1', '~AC_ARRSix1'}

## Test 'ACs with any submitted meta-review'
send_email('ACs with any submitted meta-review', 'area_chair')
assert users_with_message('ACs with any submitted meta-review', area_chairs) == {'~AC_ARROne1'}

## Test 'ACs with assigned checklists, not all completed'
send_email('ACs with assigned checklists, not all completed', 'area_chair')
emailed_users = users_with_message('ACs with assigned checklists, not all completed', area_chairs)
Expand Down