Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JacksonJavaxToJakarta] Rewrite JacksonJaxbJsonProvider to JacksonXmlBindJsonProvider #655

Conversation

FieteO
Copy link
Contributor

@FieteO FieteO commented Jan 5, 2025

What's changed?

This PR declares an additional ChangeType step in the jakarta-ee-9.yml to rewrite JacksonJaxbJsonProvider to JacksonXmlBindJsonProvider.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@FieteO FieteO changed the title Rewrite JacksonJaxbJsonProvider to JacksonXmlBindJsonProvider [JacksonJavaxToJakarta] Rewrite JacksonJaxbJsonProvider to JacksonXmlBindJsonProvider Jan 5, 2025
@timtebeek timtebeek self-requested a review January 5, 2025 12:16
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/java/migrate/UpdateSdkMan.java
    • lines 36-36

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this covered, thanks!

@timtebeek timtebeek merged commit 46a5d0a into openrewrite:main Jan 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[JacksonJavaxToJakarta] JacksonJaxbJsonProvider not rewritten to JacksonXmlBindJsonProvider
2 participants