-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate variable name in if statement with two different instanceof #175
Duplicate variable name in if statement with two different instanceof #175
Conversation
…tement with two different instanceof"
rewrite-static-analysis/src/main/java/org/openrewrite/staticanalysis/InstanceOfPatternMatch.java Lines 424 to 426 in 2fb2bfb
|
Stepped through this case with the debugger; the problem here seems to be that once we process the second |
…nt_with_two_different_instanceof
…nt_with_two_different_instanceof
…nt_with_two_different_instanceof
…nt_with_two_different_instanceof
Exploring a likely fix in |
…nt_with_two_different_instanceof
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests @KoTurk & exploring a fix. Was a more of a puzzle than anticipated, but this current iteration already improves things enough to warrant a merge. There's still a known case uncovered, but I'll stop here for today.
Added failing JUnit test for issue "Duplicate variable name in if statement with two different instanceof"
What's changed?
Created a failing JUnit test for the issue.
TODO: fix the issue
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Be kind, it's my first contribution to Open Source :-)
Anyone you would like to review specifically?
@timtebeek
Checklist
./gradlew licenseFormat