CleanupMockitoImports should not remove used mockito kotlin imports #539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Add a NoMissingTypes Precondition to CleanupMockitoImports, to prevent changes if types are missing
What's your motivation?
Fix issue where
org.mockito.kotlin
imports were being removed although they were in use.Following suggestion by @timtebeek in Slack channel.
Anything in particular you'd like reviewers to focus on?
Possibly the unit test should use a Kotlin code block and not a Java one? not sure about this.
Anyone you would like to review specifically?
@timtebeek
Checklist