[4837] PoC of options when removing 'redundant' managed dependencies #5016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 biggest needs. Don't remove if has config other than GAV+exclusion option and synchronize the version as opposed to remove. Everything is still govered by `Comparator`. This does not have impl for synchronize case (which is the big one we need:) But wanted to get something out there. Impl is real procedural, but biggest problem I see is the name. Are we still going to use 'Remove..' if an option is to 'synchronize'. I lean towards just leave it, but I'm a fan of good names.
crankydillo
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rewrite-maven/src/main/java/org/openrewrite/maven/RemoveRedundantDependencyVersions.java
Outdated
Show resolved
Hide resolved
rewrite-maven/src/test/java/org/openrewrite/maven/RemoveRedundantDependencyVersionsTest.java
Outdated
Show resolved
Hide resolved
…antDependencyVersions.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…antDependencyVersionsTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@timtebeek WDYT on this? Is this a good route? I think you could make a case the class name isn't a perfect match with this change. I'm typically pretty picky about having good names, but I'd be willing to run with this. If you think this is a good option, I'll tidy it up and move it out of draft. If not, let me know. We'll have to do an internal recipe to achieve something similar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 biggest needs. Don't remove if has config other than GAV+exclusion option and synchronize the version as opposed to remove.
Everything is still govered by
Comparator.This does not have impl for synchronize case (which is the big one we need:) But wanted to get something out there. Impl is real procedural, but biggest problem I see is the name. Are we still going to use 'Remove..' if an option is to 'synchronize'. I lean towards just leave it, but I'm a fan of good names.
Checklist