small fixes from PR review

* auto update updated_at on save() * remove unnecessary circular ref in FileReview
opensafely-core · Mar 20, 2024 · 26c9d38 · 26c9d38
1 parent cae4b7d
commit 26c9d38
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/airlock/business_logic.py b/airlock/business_logic.py
@@ -331,15 +331,12 @@ class FileReview:
     status: FileApprovalStatus
     created_at: datetime
     updated_at: datetime
-    release_request: ReleaseRequest
 
     @classmethod
     def from_dict(cls, attrs):
-        # TODO implement
         return cls(
             **{k: v for k, v in attrs.items() if k != "release_request"},
-            release_request=ReleaseRequest.from_dict(attrs.get("release_request", ())),
-            # files=[RequestFile.from_dict(value) for value in attrs.get("files", ())],
+            # release_request=ReleaseRequest.from_dict(attrs.get("release_request", ())),
         )
 
 

diff --git a/local_db/data_access.py b/local_db/data_access.py
@@ -69,7 +69,6 @@ def _get_filegroups(self, metadata: RequestMetadata):
     def _filereview(self, file_review: FileReview):
         """Convert a FileReview object into a dict"""
         return dict(
-            release_request=self._request(file_review.file.filegroup.request),
             file=self._request_file(file_review.file),
             reviewer=file_review.reviewer,
             status=file_review.status,

diff --git a/local_db/models.py b/local_db/models.py
@@ -85,7 +85,7 @@ class FileReview(models.Model):
     reviewer = models.TextField()
     status = EnumField(default=FileApprovalStatus.REJECTED, enum=FileApprovalStatus)
     created_at = models.DateTimeField(default=timezone.now)
-    updated_at = models.DateTimeField(default=timezone.now)
+    updated_at = models.DateTimeField(auto_now=True)
 
     class Meta:
         unique_together = ("file", "reviewer")