Merge pull request #191 from opensafely-core/immute-the-cache

Add `immutable` to Cache-Control headers
opensafely-core · Mar 21, 2024 · 6259c3a · 6259c3a
2 parents 1f3e848 + 5c4dc02
commit 6259c3a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/airlock/renderers.py b/airlock/renderers.py
@@ -67,7 +67,7 @@ def headers(self):
         return {
             "ETag": self.etag,
             "Last-Modified": self.last_modified,
-            "Cache-Control": f"max-age={self.MAX_AGE}",
+            "Cache-Control": f"max-age={self.MAX_AGE}, immutable",
         }
 
 

diff --git a/tests/unit/test_renderers.py b/tests/unit/test_renderers.py
@@ -45,7 +45,7 @@ def test_renderers_get_renderer_workspace(
     assert response.headers["Content-Type"].split(";")[0] == mimetype
     assert response.headers["Last-Modified"] == renderer.last_modified
     assert response.headers["ETag"] == renderer.etag
-    assert response.headers["Cache-Control"] == "max-age=31536000"
+    assert response.headers["Cache-Control"] == "max-age=31536000, immutable"
 
 
 @pytest.mark.parametrize("suffix,mimetype,template_path", RENDERER_TESTS)
@@ -80,4 +80,4 @@ def test_renderers_get_renderer_request(tmp_path, rf, suffix, mimetype, template
     assert response.headers["Content-Type"].split(";")[0] == mimetype
     assert response.headers["Last-Modified"] == renderer.last_modified
     assert response.headers["ETag"] == renderer.etag
-    assert response.headers["Cache-Control"] == "max-age=31536000"
+    assert response.headers["Cache-Control"] == "max-age=31536000, immutable"