Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for rendering images #135

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Add support for rendering images #135

merged 3 commits into from
Mar 5, 2024

Commits on Mar 5, 2024

  1. fix errant js comment formatting

    @bloodearnest
    bloodearnest committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    db35727 View commit details
    Browse the repository at this point in the history

  2. Add views to serve file contents directly. 

    This has two main benefits:
 - we can use `src=url` for iframes and img tags
 - the browser can cache these urls
    @bloodearnest
    bloodearnest committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    52c6f92 View commit details
    Browse the repository at this point in the history

  3. Add support for images 

    This uses the contents urls added in previous commit to support
rendering images. It slightly formalises the concept of a display type,
and groups different files into a specific display type.

It also fixes the double scroll bars for the iframe, and a driveby table
style fix

Fixes #127
    @bloodearnest
    bloodearnest committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    31f00e3 View commit details
    Browse the repository at this point in the history