Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable add-file-to-request button for output-checkers #150

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Disable add-file-to-request button for output-checkers #150

merged 1 commit into from
Mar 7, 2024

Conversation

rebkwok
Copy link
Contributor

@rebkwok rebkwok commented Mar 6, 2024 •
edited
Loading

if they do not have explicit permission for the workspace.

Fixes #141

@rebkwok
Disable add-file-to-request button for output-checkers
7e2a08b 
if they do not have explicit permission for the workspace.
bloodearnest
bloodearnest reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@bloodearnest bloodearnest left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also check for the permission in the add_file_to_request POST view as well?

EDIT Ah, we already do that, right?

@rebkwok
Copy link
Contributor Author

rebkwok commented Mar 7, 2024

EDIT Ah, we already do that, right?
Yes, we do, that's how I came across this issue in the first place :)

@rebkwok rebkwok merged commit b37e513 into main Mar 7, 2024
8 checks passed
@rebkwok rebkwok deleted the disable-add-file-button branch March 7, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bloodearnest bloodearnest bloodearnest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide "add file to request" for output checkers if they can't create a release
2 participants
@rebkwok @bloodearnest