Show all file content in iframes #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means changing the contents url for files to render csv/txt files as html, and just serve up other files. Also, I split the download parts of serve_file into its own function, as serve_file is more complex, and the caching logic doesn't apply to downloads. Changed some test assertions to assert that the url to the content is present, rather than the content itself.
bloodearnest
force-pushed
the
all-file-content-as-urls
branch
from
6423de4
to
914f3a2
Compare
This means we will return 304s if the file contents have not changed, which means the browser cache will be used, and we don't need to render the content. For larger files, especially csv or text, this avoids a lot of work. For content that we render (text and csv atm), the etag is a bit more involved. We want the etag value to capture both the original file and the template file that was used. This is so that if either changes, the cache is invalid and the new content is served. To do this, I added a micro rendering framework that ties the templating together with the rendering, so that we can inspect the template and check *before* doing the potentially expensive rendering.
bloodearnest
force-pushed
the
all-file-content-as-urls
branch
from
837c0b0
to
e4bbf4d
Compare
This helps view larger files in detail
rebkwok
approved these changes
Mar 18, 2024
|
|
||
| return wrapper | ||
|
|
||
| return decorator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142