Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement file approval backend #174

Merged
merged 16 commits into from
Mar 22, 2024
Merged

Implement file approval backend #174

merged 16 commits into from
Mar 22, 2024

Commits on Mar 21, 2024

  1. Rename Status to RequestStatus

    @madwort
    madwort committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    e375813 View commit details
    Browse the repository at this point in the history

  2. add FileApprovalStatus

    @madwort
    madwort committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    64de32a View commit details
    Browse the repository at this point in the history

  3. Create FileReview model

    @madwort
    madwort committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    bac48bd View commit details
    Browse the repository at this point in the history

  4. Create approve_file methods

    @madwort
    madwort committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    ba38dc8 View commit details
    Browse the repository at this point in the history

  5. implement reject_file

    @madwort
    madwort committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    3f80007 View commit details
    Browse the repository at this point in the history

  6. Add business logic layer FileReview

    @madwort
    madwort committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    7d7d3d7 View commit details
    Browse the repository at this point in the history

  7. fix ruff

    @madwort
    madwort committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    a461e48 View commit details
    Browse the repository at this point in the history

  8. Remove error handlers 

    * because we are only unit testing the BLL and not the DAL currently,
  these handlers cause test coverage to dip from 100% to 99.88%.
    @madwort
    madwort committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    30d2c36 View commit details
    Browse the repository at this point in the history

  9. Clarify is_supporting_file argument 

    is_supporting_file identifies whether a file is a supporting file
from a UrlPath. This is different to a ReleaseFile's relpath (it
includes the filegroup, which is part of the url for a release file,
but is not part of the relpath, which comes from its location in the
workspace).
    @rebkwok @madwort
    rebkwok authored and madwort committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    2a9116c View commit details
    Browse the repository at this point in the history

  10. Raise ApprovalPermissionDenied for supporting files

    @rebkwok @madwort
    rebkwok authored and madwort committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    3e9ca97 View commit details
    Browse the repository at this point in the history

  11. Use convention of user as last arg 

    * as per PR review
    @madwort
    madwort committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    cfbcbb5 View commit details
    Browse the repository at this point in the history

  12. auto-update the FileReview updated_at field

    @madwort
    madwort committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    0fb7488 View commit details
    Browse the repository at this point in the history

  13. remove dal.get_file_approvals in favour of RequestFile.reviews 

    * as per PR review
    @madwort
    madwort committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    33034dc View commit details
    Browse the repository at this point in the history

  14. Rename more Status to RequestStatus

    @madwort
    madwort committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    86eaf67 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Merge branch 'main' into madwort/implement-file-approval-backend

    @madwort
    madwort authored Mar 22, 2024
    Configuration menu
    Copy the full SHA
    6fe7310 View commit details
    Browse the repository at this point in the history

  2. Rename FileApprovalStatus -> FileReviewStatus

    @madwort
    madwort committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    841f2a9 View commit details
    Browse the repository at this point in the history