Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom otel traces #189

Merged
merged 7 commits into from
Mar 21, 2024
Merged

Custom otel traces #189

merged 7 commits into from
Mar 21, 2024

Conversation

rebkwok
Copy link
Contributor

@rebkwok rebkwok commented Mar 21, 2024

Adds an @instrument function decorator, following this post, plus some extra options to retrieve arg/kwarg values from the function signature, so we can add in the workspace name / request id.

Adds tracing for all request views, workspace views, get_workspace_tree and get_request_tree. Leaving the rendering for another PR.

Copy link
Member

@bloodearnest bloodearnest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

I think we should add this decorator to job-server/runner too!

@rebkwok rebkwok merged commit 1f3e848 into main Mar 21, 2024
8 checks passed
@rebkwok rebkwok deleted the traces branch March 21, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants