Clean up the otel config #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bloodearnest
force-pushed
the
fix-odd-config
branch
2 times, most recently
from
54c282d
to
8ed9a9f
Compare
madwort
reviewed
Mar 22, 2024
madwort
reviewed
Mar 22, 2024
madwort
approved these changes
Mar 22, 2024
bloodearnest
force-pushed
the
fix-odd-config
branch
from
aaeacc1
to
227f65e
Compare
The value PYTHONPATH made no sense. And its only required to be present not set. So I incorporated that in the code Likewise, set a default DJANGO_SETTINGS_MODULE in the right place. Also flipped OTEL_EXPORTER_CONSOLE to off by default, as its very verbose.
bloodearnest
force-pushed
the
fix-odd-config
branch
from
227f65e
to
ab91a1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of PYTHONPATH made no sense. And its only required to be present in the env, it can be set to nothing. So I incorporated that in the code
Likewise, set a default DJANGO_SETTINGS_MODULE in the right place.
Also flipped OTEL_EXPORTER_CONSOLE to off by default, as its very
verbose.