Update T1OO logic #1033
Closed
Update T1OO logic #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handling of different values of the `?include_t1oo` parameter is already tested in `test_tpp_backend_modify_dsn`. Here we want to test the query behaviour.
We expand the logic to exclude living, de-registered patients on the basis that they may have registered a T1OO elsewhere which has not propagated to our database.
evansd
force-pushed
the
evansd/t1oo-update
branch
2 times, most recently
from
afa3c77
to
04abec1
Compare
These were sensitive to the exact number of joins the T1OO logic used.
evansd
force-pushed
the
evansd/t1oo-update
branch
from
04abec1
to
d6963ef
Compare
inglesp
approved these changes
Jul 11, 2024
|
Closing in favour of #1034 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expand the logic to exclude living, de-registered patients on the basis that they may have registered a T1OO elsewhere which has not propagated to our database.