Test the setup_default_tracing() #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resulted in some fix to the configuration too, as consuming OTEL_SERVICE_NAME was not being done correctly It does involve some messy reaching into otel internals though
rebkwok
approved these changes
Mar 20, 2024
| monkeypatch.setattr(os, "environ", env) | ||
| monkeypatch.setattr( | ||
| opentelemetry.exporter.otlp.proto.http.trace_exporter, "environ", env | ||
| ) |
There was a problem hiding this comment.
just curious - why doesn't monkeypatching os also change it here? Is it just because opentelemetry.exporter.otlp.proto.http.trace_exporter does from os import environ rather than just import os, or is there something else going on?
There was a problem hiding this comment.
That is exactly what is going on, sadly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resulted in some fix to the configuration too,
as consuming OTEL_SERVICE_NAME was not being done correctly
It does involve some messy reaching into otel internals though