Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test under python 3.10 #737

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Test under python 3.10 #737

merged 2 commits into from
Aug 21, 2024

Conversation

bloodearnest
Copy link
Member

Whilst we are still not running job-server inside docker, we need
job-runner to work under the system python. Currently, TPP is on
20.04/pyh38, andw e want to upgrade to 22.04/py3.10

job-runner does work on 3.10, as its bundled in opensafely-cli, and
that's been running on 3.10 fine for anyone on 22.04 for ages.

But this formalises it in CI.

Whilst we are still not running job-server inside docker, we need
job-runner to work under the system python. Currently, TPP is on
20.04/pyh38, andw e want to upgrade to 22.04/py3.10

job-runner does work on 3.10, as its bundled in opensafely-cli, and
that's been running on 3.10 fine for anyone on 22.04 for ages.

But this formalises it in CI.
Copy link
Contributor

@rebkwok rebkwok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it also test on ubuntu-22.04 instead of 20.04? Or is the plan to change this after tpp is upgraded?

@bloodearnest
Copy link
Member Author

Should it also test on ubuntu-22.04 instead of 20.04? Or is the plan to change this after tpp is upgraded?

That's a good idea, will add.

@bloodearnest bloodearnest force-pushed the test-in-3.10 branch 3 times, most recently from 901007f to c46c76d Compare August 20, 2024 15:20
@bloodearnest bloodearnest merged commit a4e9cb4 into main Aug 21, 2024
20 checks passed
@bloodearnest bloodearnest deleted the test-in-3.10 branch August 21, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants