Add a dedicated manual maintenance mode flag #757
Conversation
bloodearnest
force-pushed
the
manual-db-maintenance-mode
branch
from
780858e
to
e8d1067
Compare
Currently, manually enabling database maintenance mode is awkward, as by default it will just get switch off again by the regular automatic check. So you have to remember to stop that first, which is awkward, then restart it, for more awkwardness Instead, this change adds an explicit flag check for `manual-db-maintenance` - if that is set, we skip the automated check altogether. This will be added to the jobrunner justfile in backend-server as a documented command in a separate PR.
bloodearnest
force-pushed
the
manual-db-maintenance-mode
branch
from
e8d1067
to
f62c9c8
Compare
There was a problem hiding this comment.
:+1 I can definitely think of previous situations where this would have saved time and confusion.
As an aside (not a comment on this PR) we're use the string "db-maintenance" an awful lot in the code. It would seem worth replacing with a constant, given how easy I find it to misspell "maintenance".
Yeah, I think we should probably change the name of the flag from I will add a constant for now |
Currently, manually enabling database maintenance mode is awkward, as by
default it will just get switch off again by the regular automatic
check. So you have to remember to stop that first, which is awkward,
then restart it, for more awkwardness
Instead, this change adds an explicit flag check for
manual-db-maintenance- if that is set, we skip the automated checkaltogether.
This will be added to the jobrunner justfile in backend-server as
a documented command in a separate PR.