fix: Bump pipeline version #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
alarthast
force-pushed
the
bump-pipeline
branch
2 times, most recently
from
a12c738
to
f9dfe63
Compare
evansd
reviewed
Oct 14, 2024
pyproject.toml
Outdated
| @@ -14,7 +14,7 @@ classifiers = [ | |||
| ] | |||
| requires-python = ">=3.8" | |||
| dependencies = [ | |||
| "opensafely-pipeline @ git+https://github.com/opensafely-core/[email protected].08.124104", | |||
| "opensafely-pipeline[fastparser] @ git+https://github.com/opensafely-core/[email protected].11.170331", | |||
There was a problem hiding this comment.
Ah sorry, confusingly job-runner can't depend on the fastparser extra because it ends up vendored inside opensafely-cli and we can't vendor compiled dependencies. This is part of the Gordian knot we trying to cut by switching to uv.
There was a problem hiding this comment.
Got it, I will switch it back :)
There was a problem hiding this comment.
We can't hard depend on it for the above reason, but we could add it to the job-runner-dependencies so we get the benefit in job-runner in prod.
There was a problem hiding this comment.
Ah yeah, I hadn't thought of that.
alarthast
force-pushed
the
bump-pipeline
branch
from
f9dfe63
to
7e59d18
Compare
evansd
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project.yamlfiles with empty actions