Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support multiple versions in pull command #239

Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix: support multiple versions in pull command #239

merged 2 commits into from
Dec 12, 2023

Conversation

bloodearnest
Copy link
Member

  • Add opensafely label in image filters.
  • Support v2 python in opensafely pull

@bloodearnest bloodearnest linked an issue Dec 12, 2023 that may be closed by this pull request
Update opensafely pull to handle multiple versions #240
Closed
ghickman
ghickman approved these changes Dec 12, 2023
View reviewed changes
opensafely/pull.py Outdated Show resolved Hide resolved
opensafely/pull.py Outdated Show resolved Hide resolved
@bloodearnest bloodearnest changed the title pull version feat: support multiple versions in pull command Dec 12, 2023
@bloodearnest
Add opensafely label in image filters.
570e1f3 
Also refactors test expectations around local images to avoid
repetition.
@bloodearnest
Support v2 python in opensafely pull
bae765c 
This reworks the pull code always be explicit about image verstion,
rather than implicitly assuming defaults.  It also sets the default
version for a generic "python" pull to be v2.

It worked out a bit cleaner that previously, and thus got rid of a test.

One slight wrinkle: previously `opensafely pull all --force` would pull
*all* available images, whether you already had them or not. It still
works similarly, but will now only pull the *default* versions of each
image.  When we figure out a way to multiple available versions for each
image type, we can fix that.
@bloodearnest bloodearnest changed the title feat: support multiple versions in pull command fix: support multiple versions in pull command Dec 12, 2023
@bloodearnest bloodearnest merged commit cb1c3ef into main Dec 12, 2023
6 checks passed
@bloodearnest bloodearnest deleted the pull-version branch December 12, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghickman ghickman ghickman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update opensafely pull to handle multiple versions
2 participants
@bloodearnest @ghickman