Add rstudio-server to r image as rstudio image #164
+172
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remlapmot
force-pushed
the
investigate-rstudio-server-iteration-3-root-squashed
branch
from
1c9786c
to
437d127
Compare
bloodearnest
reviewed
Oct 1, 2024
bloodearnest
reviewed
Oct 1, 2024
remlapmot
force-pushed
the
investigate-rstudio-server-iteration-3-root-squashed
branch
3 times, most recently
from
ba453e7
to
c8265c9
Compare
|
As suggested I have also added a test, which checks for a 200 response from the localhost port. (Nb. the test uses the rstudio image, rather than ghcr.io/opensafely-core/rstudio:latest image, as I assume the flow is build, test, publish). Run the test with |
remlapmot
force-pushed
the
investigate-rstudio-server-iteration-3-root-squashed
branch
3 times, most recently
from
cc723e1
to
9a84b47
Compare
remlapmot
force-pushed
the
investigate-rstudio-server-iteration-3-root-squashed
branch
from
9a84b47
to
5083d15
Compare
|
I have added the |
remlapmot
force-pushed
the
investigate-rstudio-server-iteration-3-root-squashed
branch
from
5083d15
to
503efc7
Compare
remlapmot
force-pushed
the
investigate-rstudio-server-iteration-3-root-squashed
branch
from
503efc7
to
97f8d9c
Compare
This is a bit cleaner and easier. Also tweak the Dockerfile to create the user with group/dir in one step, remove some uneeded bits, and give up on logs.
Easy to change and use.
This uses process substitution to tail the log file and direct it to stdout.
bloodearnest
approved these changes
Oct 15, 2024
remlapmot
force-pushed
the
investigate-rstudio-server-iteration-3-root-squashed
branch
from
c4cc77f
to
98c6beb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds rstudio-server to the r image, as a new rstudio image.
Build with
Then until rstudio image published in ghcr.io/opensafely-core retag as
Is used by the new
opensafely rstudiosubcommand in opensafely-core/opensafely-cli#272.To launch, from an OpenSAFELY research repo run
opensafely rstudio