Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cohortextractor with ehrql #110

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

inglesp
Copy link
Contributor

@inglesp inglesp commented Nov 7, 2023

Fixes #108

@@ -4,15 +4,8 @@ expectations:
population_size: 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer relevant with ehrQL and therefore a source of confusion to have it here. But currently the pipeline validator insists that this be defined for version 3.0 project.yaml files:
https://github.com/opensafely-core/pipeline/blob/8c706d663fb2fcae279bc0f15c1b1b3bd4314e99/pipeline/models.py#L186-L211

So I think we're going to have to move to version 4 for project.yaml files and create a new release of the pipeline library, which is incredibly tedious.

For now, I wonder if we should just stick a comment above this expectations section saying something like "Please ignore this section, it is not used and will be removed in future versions."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@inglesp inglesp force-pushed the replace-cohortextractor-with-ehrql branch from 08f64b7 to cc204eb Compare November 7, 2023 13:08
@inglesp inglesp merged commit 25cf5b6 into main Nov 7, 2023
1 check passed
@inglesp inglesp deleted the replace-cohortextractor-with-ehrql branch November 7, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace cohort-extractor with ehrQL
2 participants