Make tantivy queries a bit lighter #171
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbothma
reviewed
Aug 27, 2024
Comment on lines
+129
to
+130
| for word in clean.split(WS): | ||
| fields[type.name].add(word) |
There was a problem hiding this comment.
do we need to index each word individually? I thought it's sufficient to index the full name as long as we query for each part
There was a problem hiding this comment.
tantivy definitely has its own tokenizer, I just thought if we're going to split it up for phonetic anyway, why not use those tokens :) but yeah we can obviously rely on the real indexer instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the clauses in the tantivy query down a bit, hoping that lighter queries will equal a faster xref.
WIP