Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement usermap exponential backoff (INF-1310) #16

Conversation

williamnswanson
Copy link
Collaborator

Update usermap script to use exponential backoff. The minimum and maximum timeouts can be set with options.

The minimum and maximum timeouts can be set with options.
Just to fix the options formatting
Copy link
Member

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would get the job done but I'm more interested in actually implementing an exponential timeout: try 5, 25, 125, and 625 seconds and then give up. I'm also fine if it's not configurable via option

osg-comanage-project-usermap.py Outdated Show resolved Hide resolved
osg-comanage-project-usermap.py Outdated Show resolved Hide resolved
Copy link
Member

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, I guess that is exponential! It's a little complicated but it'll do

osg-comanage-project-usermap.py Outdated Show resolved Hide resolved
osg-comanage-project-usermap.py Outdated Show resolved Hide resolved
@brianhlin brianhlin dismissed their stale review November 6, 2023 22:50

Brian can't read code

@brianhlin brianhlin changed the title Inf 1310.usermap script backoff Implement usermap exponential backoff (INF-1310) Nov 6, 2023
@brianhlin
Copy link
Member

I also updated the PR title (see https://osg-htc.org/technology/software/git-software-development/#summarize-your-commits-in-the-pull-request-title), partially because the title makes its way into the merge commit so we want it to summarize the changes in a human-readable way. Also, Jira will look for the ticket key in commits/title so you want that to be well-formatted

Modified var names and default values
Copy link
Member

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@williamnswanson williamnswanson merged commit 6e0c200 into opensciencegrid:master Nov 7, 2023
3 checks passed
@williamnswanson williamnswanson deleted the INF-1310.usermap-script-backoff branch November 7, 2023 21:59
@williamnswanson williamnswanson restored the INF-1310.usermap-script-backoff branch November 7, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants