-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement usermap exponential backoff (INF-1310) #16
Implement usermap exponential backoff (INF-1310) #16
Conversation
The minimum and maximum timeouts can be set with options.
Just to fix the options formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would get the job done but I'm more interested in actually implementing an exponential timeout: try 5, 25, 125, and 625 seconds and then give up. I'm also fine if it's not configurable via option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait, I guess that is exponential! It's a little complicated but it'll do
I also updated the PR title (see https://osg-htc.org/technology/software/git-software-development/#summarize-your-commits-in-the-pull-request-title), partially because the title makes its way into the merge commit so we want it to summarize the changes in a human-readable way. Also, Jira will look for the ticket key in commits/title so you want that to be well-formatted |
Modified var names and default values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Brian Lin <[email protected]>
Update usermap script to use exponential backoff. The minimum and maximum timeouts can be set with options.