Change osggid assigner script to do project group setup (SOFTWARE-5619) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhlin
requested changes
Dec 5, 2023
There was a problem hiding this comment.
In addition to the comments in-line, I've got a few general thoughts:
- There's a lot of duplication with
group_fixup.pythat should be refactored out into a separate library - Lots of your logic is crammed into
main(). You should split it out into small functions and call them - More comments! Some parts of the script are a little unclear and reviewing would be a bit easier with some explanations on the side.
- It's better to ask for forgiveness than for permission! There are a few spots in your script where your
ifstatements should just betry/except. It'll help with some of the deep nesting and thus readability of the script
williamnswanson
force-pushed
the
SOFTWARE-5619.assign-new-project-gids
branch
2 times, most recently
from
998ffc3 to
efdd969
Compare
williamnswanson
force-pushed
the
SOFTWARE-5619.assign-new-project-gids
branch
from
efdd969 to
458af37
Compare
Also, move get_projects_to_setup() functionality into several different methods for clarity.
williamnswanson
force-pushed
the
SOFTWARE-5619.assign-new-project-gids
branch
from
40b6445 to
172acae
Compare
Created a file to hold methods that are, or will likely be, used by multiple scripts in the osg-comanage-rpoject-usermap repo. Refactored existing scripts to use the new library.
Projects that needed an OSGGID identifier weren't being provisioned if a UNIX cluster group already existed. Added identifier updating after adding missing identifiers and moved adding identifiers to before checking what projects need UNIX cluster groups and provisioning.
williamnswanson
force-pushed
the
SOFTWARE-5619.assign-new-project-gids
branch
from
172acae to
6978619
Compare
No functional changes
brianhlin
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add UNIX Cluster Group creation and LDAP Provisioning to the osggid assigner script.
Also renamed the script to "project_group_setup" to fit it's new role.