Add Origin Information to Namespace Endpoint (SOFTWARE-5629) #3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CannonLock
force-pushed
the
add-origin
branch
2 times, most recently
from
4751f99
to
3ccf9d6
Compare
|
Tested by sorting the results, then comparing the current and the new response to make sure the only thing changed was the addition of the origin information. Resulting json files are zipped below. |
|
Final changes. With a diff of the previous and the new result of this endpoint I can confirm this PR changes none of the current information, only adding origin lists to each namespace. |
matyasselmeci
requested changes
Jul 26, 2023
|
@matyasselmeci Ah, I remembered we got the webapp to 3.9 but makes sense others run this. |
CannonLock
force-pushed
the
add-origin
branch
3 times, most recently
from
3e10747
to
6f1eb73
Compare
|
Sorry for the force pushes I misspelled "remot(v)e" and then proceeded to forget how to rebase. |
|
No worries, LGTM. Can you merge or rebase on master? |
|
Once it's up to date, feel free to merge and deploy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://opensciencegrid.atlassian.net/browse/SOFTWARE-5629