Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EOS service type (SOFTWARE-5674) #3372

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Add EOS service type (SOFTWARE-5674) #3372

merged 3 commits into from
Oct 27, 2023

Conversation

matyasselmeci
Copy link
Collaborator

No description provided.

@matyasselmeci matyasselmeci changed the title Add EOS service type Add EOS service type (SOFTWARE-5674) Sep 6, 2023
brianhlin
brianhlin approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@brianhlin brianhlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's hold off merging until we get the affirmative from CRIC

@matyasselmeci
Copy link
Collaborator Author

We got the go-ahead for this.

@matyasselmeci matyasselmeci merged commit c736874 into opensciencegrid:master Oct 27, 2023
2 checks passed
@matyasselmeci matyasselmeci deleted the pr/add-eos branch October 27, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianhlin brianhlin brianhlin approved these changes

Assignees
No one assigned
Labels
do-not-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matyasselmeci @brianhlin