Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create HarvardMed_Aganj.yaml #4214

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Conversation

ChristinaLK
Copy link
Contributor

No description provided.

osg-bot
osg-bot previously requested changes Oct 3, 2024
Copy link
Collaborator

@osg-bot osg-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings @ChristinaLK,

Thank you for your pull request.

Your requested changes add a new organization or project ID to a project file; this requires manual review from OSG Staff.

-- OSG-BOT 🚔


Output from the automerge check script:

Commit is not eligible for auto-merge:
 - File 'projects/HarvardMed_Aganj.yaml' is not a downtime file.
 - Unrecognized InstitutionID in project(s) projects/HarvardMed_Aganj.yaml. See https://topology-institutions.osg-htc.org for known ID list.


@mwestphall
Copy link
Collaborator

Hi @opensciencegrid/project-office , are we good to add "Harvard Medical School" as an institution to the institutions database?

@matyasselmeci
Copy link
Collaborator

Harvard Medical School should already be in there: as https://osg-htc.org/iid/n1kbnzl7kyiv. We have other projects with that institution.

@matyasselmeci
Copy link
Collaborator

@mwestphall
Copy link
Collaborator

@matyasselmeci that might be indicative of a gap in our validation logic, the "n1kbnzl7kyiv" iid corresponds to "Harvard University" in the institutions DB. Do we want/need a separate institution for the medical school?

@matyasselmeci
Copy link
Collaborator

Good question. Harvard Medical School does not show up in ror.org: https://ror.org/search?query=Harvard+Medical+School

@matyasselmeci
Copy link
Collaborator

I take that back. The ROR registration has been withdrawn: https://ror.org/03wevmz92 with the comment "This organization is succeeded by Harvard University (https://ror.org/03vek6s52)."

@opensciencegrid/project-office in the past we have treated Harvard Medical School as a separate organization from Harvard University -- do we still want to do that?

@jstathas
Copy link
Contributor

jstathas commented Oct 3, 2024 via email

@matyasselmeci
Copy link
Collaborator

Thanks! Two more questions:

  1. Should we (if we can) change the project name from HarvardMed_Aganj to Harvard_Aganj?
  2. Should we (separately of course) change the Organizations of the other projects that use "Harvard Medical School"?

@jstathas
Copy link
Contributor

jstathas commented Oct 3, 2024 via email

@mwestphall mwestphall dismissed osg-bot’s stale review October 3, 2024 18:34

Institution renamed

@mwestphall mwestphall merged commit 4241631 into opensciencegrid:master Oct 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants