Iter #46
Merged
Iter #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #46 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 176 178 +2
Branches 25 25
=========================================
+ Hits 176 178 +2 ☔ View full report in Codecov by Sentry. |
AHReccese
reviewed
Jan 28, 2025
opr/primer.py
Outdated
Comment on lines
106
to
114
| def __iter__(self): | ||
| """ | ||
| Iterate through Primer. | ||
|
|
||
| :return: None | ||
| """ | ||
| for base in self.sequence: | ||
| yield base | ||
|
|
There was a problem hiding this comment.
you can go with this:
def __iter__(self):
"""
Iterate through Primer.
:return: Iterator[str]
"""
yield from self.sequence
There was a problem hiding this comment.
Good point ,fixed in be19663.
However, using return: None is more precise.
There was a problem hiding this comment.
when I run type(primer_instance.iter()) it is printed as: <class 'generator'> and in this case it is Generator[str].
AHReccese
approved these changes
Jan 29, 2025
Fixed in 03f8e37 |
AHReccese
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
__iter__overload addedAny other comments?