Internal Cache Flag #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #52 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 180 194 +14
Branches 23 25 +2
=========================================
+ Hits 180 194 +14 ☔ View full report in Codecov by Sentry. |
sepandhaghighi
requested changes
Feb 22, 2025
opr/primer.py
Outdated
| @@ -274,10 +305,13 @@ def melting_temperature(self, method=MeltingTemperature.BASIC): | |||
| :type method: MeltingTemperature | |||
| :return: approximated melting temperature | |||
| """ | |||
| if self._melting_temperature[method] is not None: | |||
| if method not in self._computed["melting_temperature"]: | |||
| raise OPRBaseError(PRIMER_INVALID_MELTING_TEMPERATURE_METHOD_ERROR) | |||
There was a problem hiding this comment.
This error and raise NotImplementedError(PRIMER_MELTING_TEMPERATURE_NOT_IMPLEMENTED_ERROR) are very similar; please properly merge them. I suggest raising only NotImplementedError.
CHANGELOG.md
Outdated
| - `_computed` internal cache flag attribute | ||
| - `is_computed` method | ||
| ### Changed | ||
| - Cache structure in Primer |
sepandhaghighi
requested changes
Feb 28, 2025
There was a problem hiding this comment.
@AHReccese
Please resolve this pull request conflicts and then ping me so I can complete my review 🔥
sepandhaghighi
requested changes
Mar 1, 2025
opr/params.py
Outdated
| @@ -26,3 +26,5 @@ | |||
| PRIMER_MULTIPLICATION_ERROR = "The primer sequence can only be multiplied by an integer." | |||
|
|
|||
| PRIMER_MELTING_TEMPERATURE_NOT_IMPLEMENTED_ERROR = "This method for calculating melting temperature has not been implemented." | |||
|
|
|||
| PRIMER_ATTRIBUTE_NOT_COMPUTABLE_ERROR = "This attribute either doesn't exist or cannot be computed/cached (e.g., name)." | |||
There was a problem hiding this comment.
My suggestion:
This attribute either doesn't exist or cannot be computed/cached (e.g., name).
opr/primer.py
Outdated
| @@ -11,6 +11,8 @@ | |||
| from .params import DNA_COMPLEMENT_MAP | |||
| from .params import PRIMER_ADDITION_ERROR, PRIMER_MULTIPLICATION_ERROR | |||
| from .params import PRIMER_MELTING_TEMPERATURE_NOT_IMPLEMENTED_ERROR | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#50
What does this implement/fix? Explain your changes.
Any other comments?