DNA to RNA #53
Open
DNA to RNA #53
+28
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #53 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 194 196 +2
Branches 25 25
=========================================
+ Hits 194 196 +2 ☔ View full report in Codecov by Sentry. |
AHReccese
requested changes
Mar 1, 2025
AHReccese
approved these changes
Mar 1, 2025
sepandhaghighi
requested changes
Mar 2, 2025
There was a problem hiding this comment.
@sadrasabouri Please resolve the pull request conflicts and then ping me so we can complete my review 🔥
|
@sepandhaghighi done, it's ready for your review now. |
sepandhaghighi
requested changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#4
What does this implement/fix? Explain your changes.
This PR adds
to_rnamethod toPrimerclass, transforming DNA sequence to RNA.Any other comments?
The website referred to in the issue was out of reach at the time of developing this feature. so I used other resources. As I found it only replaces
TwithUto make the RNA from DNA. However, I saw some other resources where they complement the resulting formula at the end as well. I just wanted to know if we're doing the right thing.update: the website is back to normal now and I checked all the tests and examples with that.