-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating ciceroscmpy version and tests this also gets rid of pandas <… #89
Conversation
Should I try to up the test coverage for my various help functions in this while I'm at it @znicholls ? (Otherwise this might just be a quick update version thing just to get less outdated versioning...) |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
=======================================
Coverage 70.38% 70.38%
=======================================
Files 36 36
Lines 1442 1442
Branches 194 194
=======================================
Hits 1015 1015
Misses 405 405
Partials 22 22 ☔ View full report in Codecov by Sentry. |
If you want, can also be done in a follow up PR to keep the scope of each smaller |
Seems I need to spend some time fighting with windows first, anyways... |
The error is really bizarre. The CI shows the environment at the top in case that's helpful (maybe different package versions available on windows compared to linux...) e.g. CI https://github.com/openscm/openscm-runner/actions/runs/7708984548/job/21009201207?pr=89 If you scroll to the right bit you see ![]() |
Ok, fixed the windows thing, apparently windows default int type for numpy is np.int32... Anyways, the fail now is coverage, so if the tests are supposed to go green, then I might need to work on that... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry about the coverage, that's just coverage being silly (I'll just override it when I merge).
If you can mark the PR as ready for review and make the updates then I'll merge assuming everything goes green (once it's no longer a draft, a couple more things get run which may flag further errors).
Co-authored-by: Zeb Nicholls <[email protected]>
Ok, think that covers the rest of the updates :-) |
…2 requirement