Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TESTID-125,126,127,128,129] Saved Query Test Scope Add Todo for Workaround #9287

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

ArgusLi
Copy link
Contributor

@ArgusLi ArgusLi commented Jan 28, 2025

Description

Add Todo Comment for workaround that was added to avoid rarely occurring issue.

The issue is that the Date Picker is expected to be visible when DQL is selected, however it doesn't appear. To workaround this issue, we have to reselect the data source then the query language. This leads to the Date Picker appearing.

Relates to #9229.

Screenshot

saved+queries+UI+--+should+create,+load,+update,+modify+and+delete+the+saved+query+DQL-INDEX_PATTERN+(failed)

Testing the changes

With OSD running, run yarn run cypress open. In E2E specs, you will see 1 new test spec1 saved_queries.spec.js. Run that spec.

Changelog

  • skip

Signed-off-by: Argus Li <[email protected]>
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.68%. Comparing base (969114f) to head (6f4dfe8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9287   +/-   ##
=======================================
  Coverage   61.68%   61.68%           
=======================================
  Files        3816     3816           
  Lines       91694    91694           
  Branches    14516    14516           
=======================================
  Hits        56559    56559           
  Misses      31510    31510           
  Partials     3625     3625           
Flag Coverage Δ
Linux_1 29.04% <ø> (ø)
Linux_2 56.46% <ø> (ø)
Linux_3 39.09% <ø> (ø)
Linux_4 28.97% <ø> (ø)
Windows_1 29.06% <ø> (ø)
Windows_2 56.41% <ø> (ø)
Windows_3 39.09% <ø> (ø)
Windows_4 28.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ananzh ananzh added backport 2.x v2.19.0 discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative labels Jan 28, 2025
@ananzh ananzh merged commit 5a0ad73 into opensearch-project:main Jan 28, 2025
77 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-9287-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5a0ad734a88c4a832d525302b072fef41d89122f
# Push it to GitHub
git push --set-upstream origin backport/backport-9287-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9287-to-2.x.

angle943 pushed a commit to angle943/OpenSearch-Dashboards that referenced this pull request Jan 29, 2025
Signed-off-by: Argus Li <[email protected]>
(cherry picked from commit 5a0ad73)
ananzh pushed a commit that referenced this pull request Jan 29, 2025
Signed-off-by: Argus Li <[email protected]>
(cherry picked from commit 5a0ad73)

Co-authored-by: Argus Li <[email protected]>
ruchidh pushed a commit to ruchidh/OpenSearch-Dashboards that referenced this pull request Jan 30, 2025
Signed-off-by: Argus Li <[email protected]>
Signed-off-by: Ubuntu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative failed backport repeat-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants