Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTID-116, TESTID-115, TESTID-61 - Tests for Saved Searches in Dashboard #9288

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

angle943
Copy link
Contributor

Description

Adds tests for Saved Searches in Dashboards: #8961 , #8960 , #8959

Issues Resolved

closes #8961
closes #8960
closes #8959

Changelog

  • test: add tests for saved searches in dashboards

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.72%. Comparing base (6c83d4e) to head (3595893).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9288      +/-   ##
==========================================
+ Coverage   61.70%   61.72%   +0.01%     
==========================================
  Files        3816     3816              
  Lines       91824    91824              
  Branches    14542    14542              
==========================================
+ Hits        56664    56674      +10     
+ Misses      31506    31495      -11     
- Partials     3654     3655       +1     
Flag Coverage Δ
Linux_1 28.99% <ø> (ø)
Linux_2 56.46% <ø> (ø)
Linux_3 39.18% <ø> (-0.01%) ⬇️
Linux_4 28.91% <ø> (ø)
Windows_1 29.02% <ø> (+0.01%) ⬆️
Windows_2 56.41% <ø> (ø)
Windows_3 39.18% <ø> (ø)
Windows_4 28.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cy.getElementByTestId('docTableField').should('be.visible');

// set a date where there should be no results
setDatePickerDatesAndSearchIfRelevant(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets change to a valid time range where we have atleast some hits which is different from the expected hits in the config. That will ensure that changing time ranges actually updates the underlying search.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sounds good. i'm a bit concerned though about timezone differences between my env and the CI/CD (or does that matter)? Lets see though, i'll push out a change that works on my end

@ananzh ananzh added discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative backport 2.x v2.19.0 labels Jan 28, 2025
ananzh
ananzh previously approved these changes Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.19 discover_2.0-test Issues that are specific to the Discover 2.0 testing initiative v2.19.0 valued-contributor
Projects
None yet
3 participants