Avoid list copy by casting array

Signed-off-by: Daniel Widdis <[email protected]>
opensearch-project · Jul 21, 2024 · 0a14c28 · 0a14c28
1 parent 8d11fa2
commit 0a14c28
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/...ne-common/src/main/java/org/opensearch/search/pipeline/common/SplitResponseProcessor.java b/...ne-common/src/main/java/org/opensearch/search/pipeline/common/SplitResponseProcessor.java
@@ -23,7 +23,6 @@
 import org.opensearch.search.pipeline.SearchResponseProcessor;
 
 import java.util.Arrays;
-import java.util.List;
 import java.util.Map;
 import java.util.Objects;
 
@@ -115,9 +114,10 @@ public SearchResponse processResponse(SearchRequest request, SearchResponse resp
                 if (val == null || !String.class.isAssignableFrom(val.getClass())) {
                     throw new IllegalArgumentException("field [" + splitField + "] is not a string, cannot split");
                 }
-                String[] strings = ((String) val).split(separator, preserveTrailing ? -1 : 0);
-                List<Object> splitList = List.copyOf(Arrays.asList(strings));
-                hit.setDocumentField(targetField, new DocumentField(targetField, splitList));
+                hit.setDocumentField(
+                    targetField,
+                    new DocumentField(targetField, Arrays.asList(((String) val).split(separator, preserveTrailing ? -1 : 0)))
+                );
             }
             if (hit.hasSource()) {
                 BytesReference sourceRef = hit.getSourceRef();
@@ -131,9 +131,7 @@ public SearchResponse processResponse(SearchRequest request, SearchResponse resp
                 if (sourceAsMap.containsKey(splitField)) {
                     Object val = sourceAsMap.get(splitField);
                     if (val instanceof String) {
-                        String[] strings = ((String) val).split(separator, preserveTrailing ? -1 : 0);
-                        List<Object> splitList = List.copyOf(Arrays.asList(strings));
-                        sourceAsMap.put(targetField, splitList);
+                        sourceAsMap.put(targetField, Arrays.asList(((String) val).split(separator, preserveTrailing ? -1 : 0)));
                     }
                     XContentBuilder builder = XContentBuilder.builder(typeAndSourceMap.v1().xContent());
                     builder.map(sourceAsMap);