Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs causing red indexes with remote indexes during translog upload & store recovery #10449

Merged
merged 5 commits into from
Oct 7, 2023
Merged

Fix bugs causing red indexes with remote indexes during translog upload & store recovery #10449

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
079c4d7
Disable async trim translog task for remote indexes
ashking94 Oct 6, 2023
2b17e06
Skip load global checkpoint to replication tracker for remote indexes
ashking94 Oct 6, 2023
4657a37
Add Integ Tests
ashking94 Oct 7, 2023
e0c59a6
Empty-Commit
ashking94 Oct 7, 2023
97e5b34
Empty-Commit
ashking94 Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion server/src/main/java/org/opensearch/index/shard/IndexShard.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1465,6 +1465,9 @@ public void flush(FlushRequest request) {
* {@link org.opensearch.index.translog.TranslogDeletionPolicy} for details
*/
public void trimTranslog() {
if (isRemoteTranslogEnabled()) {
return;
}
verifyNotClosed();
final Engine engine = getEngine();
engine.translogManager().trimUnreferencedTranslogFiles();
Expand Down Expand Up @@ -2314,7 +2317,7 @@ public void openEngineAndRecoverFromTranslog() throws IOException {
};

// Do not load the global checkpoint if this is a remote snapshot index
if (indexSettings.isRemoteSnapshot() == false) {
if (indexSettings.isRemoteSnapshot() == false && indexSettings.isRemoteTranslogStoreEnabled() == false) {
sachinpkale marked this conversation as resolved.
Show resolved Hide resolved
loadGlobalCheckpointToReplicationTracker();
}

Expand Down