-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce amount of docs ingested for SegRep ITs #10584
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change 23996bf Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
@mch2 Rebase? |
This change reduces the amount of docs we ingest inside SegmentReplicationIT. These tests were often ingesting 1-200 docs where it was not required. Many only required a few so that segments are created. This speeds up tests when run with remote store through SegmentReplicationUsingRemoteStore. Also add Testlogging annotation on the replication package for known flaky tests. Signed-off-by: Marc Handalian <[email protected]>
❌ Gradle check result for 23996bf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 23996bf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10584 +/- ##
============================================
- Coverage 71.15% 71.13% -0.02%
- Complexity 58783 58824 +41
============================================
Files 4885 4885
Lines 277199 277199
Branches 40285 40285
============================================
- Hits 197247 197198 -49
- Misses 63448 63514 +66
+ Partials 16504 16487 -17 ☔ View full report in Codecov by Sentry. |
This change reduces the amount of docs we ingest inside SegmentReplicationIT. These tests were often ingesting 1-200 docs where it was not required. Many only required a few so that segments are created. This speeds up tests when run with remote store through SegmentReplicationUsingRemoteStore. Also add Testlogging annotation on the replication package for known flaky tests. Signed-off-by: Marc Handalian <[email protected]> (cherry picked from commit e3bd0c3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This change reduces the amount of docs we ingest inside SegmentReplicationIT. These tests were often ingesting 1-200 docs where it was not required. Many only required a few so that segments are created. This speeds up tests when run with remote store through SegmentReplicationUsingRemoteStore. Also add Testlogging annotation on the replication package for known flaky tests. (cherry picked from commit e3bd0c3) Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This change reduces the amount of docs we ingest inside SegmentReplicationIT. These tests were often ingesting 1-200 docs where it was not required. Many only required a few so that segments are created. This speeds up tests when run with remote store through SegmentReplicationUsingRemoteStore. Also add Testlogging annotation on the replication package for known flaky tests. Signed-off-by: Marc Handalian <[email protected]>
This change reduces the amount of docs we ingest inside SegmentReplicationIT. These tests were often ingesting 1-200 docs where it was not required. Many only required a few so that segments are created. This speeds up tests when run with remote store through SegmentReplicationUsingRemoteStore. Also add Testlogging annotation on the replication package for known flaky tests. Signed-off-by: Marc Handalian <[email protected]>
This change reduces the amount of docs we ingest inside SegmentReplicationIT. These tests were often ingesting 1-200 docs where it was not required. Many only required a few so that segments are created. This speeds up tests when run with remote store through SegmentReplicationUsingRemoteStore. Also add Testlogging annotation on the replication package for known flaky tests. Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
This change reduces the amount of docs we ingest inside SegmentReplicationIT. Many of these tests were ingesting 1-200 docs where only a handful of docs were required to create segments.
This speeds up tests when run with remote store through SegmentReplicationUsingRemoteStore as each translog write is sync'd to remote store and adds latency. On my machine it takes execution time of this suite from 5-7+ mins down to ~1 min.
Also add TestLogging annotation on the replication package for known flaky tests.
Related Issues
Related flaky tests have added
@TestLogging
#10026
#9712
#9735
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.