Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for concurrent Search: TermsDocCountErrorIT #11093

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

weiwang118
Copy link
Contributor

@weiwang118 weiwang118 commented Nov 4, 2023

Description

This PR is to make sure that the index random function which is used in multiple classes has creation of multiple segments to test the concurrent search code path in the following IT:

TermsDocCountErrorIT

This change will fix 2 concurrent search tests.

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@weiwang118
Copy link
Contributor Author

@sohami @neetikasinghal Please review.

Copy link
Contributor

github-actions bot commented Nov 4, 2023

Compatibility status:

Checks if related components are compatible with change 482e5cf

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

Copy link
Contributor

github-actions bot commented Nov 4, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8077a26) 71.12% compared to head (482e5cf) 71.22%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11093      +/-   ##
============================================
+ Coverage     71.12%   71.22%   +0.09%     
- Complexity    58788    58858      +70     
============================================
  Files          4883     4883              
  Lines        277152   277152              
  Branches      40281    40281              
============================================
+ Hits         197134   197407     +273     
+ Misses        63545    63291     -254     
+ Partials      16473    16454      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weiwang118
Copy link
Contributor Author

weiwang118 commented Nov 14, 2023

@weiwang118 weiwang118 force-pushed the conc-test-changes branch 2 times, most recently from eba41d7 to e022447 Compare November 14, 2023 18:19
Copy link
Contributor

❌ Gradle check result for e022447: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for eba41d7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@weiwang118
Copy link
Contributor Author

weiwang118 commented Nov 14, 2023

Copy link
Contributor

❌ Gradle check result for fe01b95: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 2ad955a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 0698261: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for aa207eb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 5e46786: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for e26e698: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for e26e698: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 482e5cf: SUCCESS

@sohami sohami merged commit 675dd41 into opensearch-project:main Nov 15, 2023
29 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 15, 2023
Signed-off-by: Wei Wang <[email protected]>
Co-authored-by: Wei Wang <[email protected]>
(cherry picked from commit 675dd41)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sohami pushed a commit that referenced this pull request Nov 16, 2023
(cherry picked from commit 675dd41)

Signed-off-by: Wei Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Wei Wang <[email protected]>
fahadshamiinsta pushed a commit to fahadshamiinsta/OpenSearch270 that referenced this pull request Dec 4, 2023
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants