-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests for concurrent Search: TermsDocCountErrorIT #11093
Conversation
@sohami @neetikasinghal Please review. |
Compatibility status:Checks if related components are compatible with change 482e5cf Incompatible componentsIncompatible components: [https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Gradle Check (Jenkins) Run Completed with:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11093 +/- ##
============================================
+ Coverage 71.12% 71.22% +0.09%
- Complexity 58788 58858 +70
============================================
Files 4883 4883
Lines 277152 277152
Branches 40281 40281
============================================
+ Hits 197134 197407 +273
+ Misses 63545 63291 -254
+ Partials 16473 16454 -19 ☔ View full report in Codecov by Sentry. |
eba41d7
to
e022447
Compare
❌ Gradle check result for e022447: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
e022447
to
fe01b95
Compare
❌ Gradle check result for eba41d7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
fe01b95
to
2ad955a
Compare
❌ Gradle check result for fe01b95: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 2ad955a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
2ad955a
to
0698261
Compare
❌ Gradle check result for 0698261: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
0698261
to
aa207eb
Compare
❌ Gradle check result for aa207eb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
aa207eb
to
5e46786
Compare
❌ Gradle check result for 5e46786: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
5e46786
to
e26e698
Compare
❌ Gradle check result for e26e698: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for e26e698: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Wei Wang <[email protected]>
e26e698
to
482e5cf
Compare
Signed-off-by: Wei Wang <[email protected]> Co-authored-by: Wei Wang <[email protected]> (cherry picked from commit 675dd41) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 675dd41) Signed-off-by: Wei Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Wei Wang <[email protected]>
…ject#11093) Signed-off-by: Wei Wang <[email protected]> Co-authored-by: Wei Wang <[email protected]>
…ject#11093) Signed-off-by: Wei Wang <[email protected]> Co-authored-by: Wei Wang <[email protected]>
…ject#11093) Signed-off-by: Wei Wang <[email protected]> Co-authored-by: Wei Wang <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
This PR is to make sure that the index random function which is used in multiple classes has creation of multiple segments to test the concurrent search code path in the following IT:
This change will fix 2 concurrent search tests.
Related Issues
Check List
New functionality has been documented.New functionality has javadoc addedCommit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.