Disable index refresh for TermsFixedDocCountErrorIT

[jed326]

Description

Set index refresh interval to -1, should make segment count for these tests stable. Ran offline 10k times.

Related Issues

Resolves #11950

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Compatibility status:

Checks if related components are compatible with change ad4b59f

Incompatible components

Incompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/sql.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security.git]

[github-actions]

❕ Gradle check result for ad4b59f: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (761e13b) 70.86% compared to head (ad4b59f) 71.35%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11976      +/-   ##
============================================
+ Coverage     70.86%   71.35%   +0.48%     
- Complexity    58982    59375     +393     
============================================
  Files          4923     4923              
  Lines        279214   279214              
  Branches      40596    40596              
============================================
+ Hits         197877   199242    +1365     
+ Misses        64876    63418    -1458     
- Partials      16461    16554      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jed326]

@reta or @dblock could you please help review? Should be a quick one

[neetikasinghal]

@jed326 LGTM, quick question though: why did you choose to keep the refresh interval to be -1? is this same as setting the refresh policy as IMMEDIATE?

[jed326]

@jed326 LGTM, quick question though: why did you choose to keep the refresh interval to be -1? is this same as setting the refresh policy as IMMEDIATE?

The accuracy checks in these tests depend on the documents to be indexed into specific segments, which I am trying to do with the manual refresh calls.

By default, the refresh interval is 1s, so what that means is that refresh will get automatically called on these indices every 1s. I believe that is what happened in the reported test failure, where we saw 3 segments instead of the expected 2 segments. So basically it's the opposite of using refresh policy IMMEDIATE.

[neetikasinghal]

@jed326 LGTM, quick question though: why did you choose to keep the refresh interval to be -1? is this same as setting the refresh policy as IMMEDIATE?

The accuracy checks in these tests depend on the documents to be indexed into specific segments, which I am trying to do with the manual refresh calls.

By default, the refresh interval is 1s, so what that means is that refresh will get automatically called on these indices every 1s. I believe that is what happened in the reported test failure, where we saw 3 segments instead of the expected 2 segments. So basically it's the opposite of using refresh policy IMMEDIATE.

got it, so basically we are trying to avoid the auto-refresh calls and letting the manual refresh control the regulation of refresh. Is that correct understanding?

[neetikasinghal]

@jed326 looks like the tests weren't running with concurrent search as enabled with a bug present, please validate your PR once this PR gets merged.

[jed326]

@jed326 looks like the tests weren't running with concurrent search as enabled with a bug present, please validate your PR once this PR gets merged.

@neetikasinghal I don't think the issue linked is related to this PR since these tests are TEST scoped. Moreover, the tests themselves would not be finding the correct document count error if concurrent path is not being executed because the error comes from the slice level.

[reta]

@jed326 looks like the tests weren't running with concurrent search as enabled with a bug present, please validate your PR once this PR gets merged.

This is correct, the issue was only affecting suite scoped tests, this test case should not be affected

[neetikasinghal]

@jed326 looks like the tests weren't running with concurrent search as enabled with a bug present, please validate your PR once this PR gets merged.

This is correct, the issue was only affecting suite scoped tests, this test case should not be affected

yes @reta, I verified that the TEST scope tests are taking the concurrent search path.