Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregation filter rewrite optimization follow up #15078

Closed
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
3f43898
Refactor
bowenlan-amzn Jun 19, 2024
7d9d57e
Refactor
bowenlan-amzn Jun 19, 2024
1a067ba
Refactor
bowenlan-amzn Jun 19, 2024
e8e9ad3
Refactor
bowenlan-amzn Jun 20, 2024
7c491b9
Refactor
bowenlan-amzn Jun 20, 2024
a158f78
Refactor
bowenlan-amzn Jun 21, 2024
8f10faf
Refactor
bowenlan-amzn Jun 21, 2024
6c097f3
Fix a bug
bowenlan-amzn Jun 21, 2024
40c42fa
address comment
bowenlan-amzn Jul 2, 2024
5fde041
prepareFromSegment now doesn't return Ranges
bowenlan-amzn Jul 2, 2024
510a052
how it looks like when introduce interfaces
bowenlan-amzn Jul 2, 2024
4a333af
remove interface, clean up
bowenlan-amzn Jul 2, 2024
9325061
improve doc
bowenlan-amzn Jul 2, 2024
bf958ea
Merge branch 'main' into 14435-refactor-range-agg-optimization
bowenlan-amzn Jul 2, 2024
5439401
Merge branch 'main' into 14435-refactor-range-agg-optimization
bowenlan-amzn Jul 10, 2024
3a60a81
move multirangetraversal logic to helper
bowenlan-amzn Jul 10, 2024
094c25b
improve the refactor
bowenlan-amzn Jul 17, 2024
7c44da1
Add sub agg support for fast filter optmization - RangeAgg + DateHist…
finnegancarroll Jul 18, 2024
adda80a
Add yaml rest test for data histo sub agg
finnegancarroll Jul 18, 2024
b3f9066
Avoid visiting individual docIDs
finnegancarroll Jul 22, 2024
942c4e7
Fix histogram - range yaml rest test
finnegancarroll Jul 22, 2024
2a69ed3
Disable sub aggs on composite date histo
finnegancarroll Jul 23, 2024
2290c12
No need to scrutinize doc values when CELL_INSIDE_QUERY
finnegancarroll Jul 29, 2024
aa36c32
histo and range sub agg rest api tests
finnegancarroll Jul 29, 2024
fbbdc45
Range with auto date sub agg rest test
finnegancarroll Jul 26, 2024
5568618
Re-apply must visit every leaf to collect doc id
finnegancarroll Jul 31, 2024
ad27f81
Micro benchmark for collect doc ids with multiRangeTraverseTree
finnegancarroll Jul 31, 2024
a0aabe2
Set node name in log config to avoid console barf
finnegancarroll Jul 31, 2024
d5dfbed
Remove collector from intersectWithRanges - not used
finnegancarroll Jul 31, 2024
9bd6094
Remove un used import/var
finnegancarroll Jul 31, 2024
cae9864
Move all range checking functionality to Ranges
finnegancarroll Aug 1, 2024
b340a55
Move tree traversal functionality into single IntersectVisitor child …
finnegancarroll Aug 1, 2024
7b1f8e4
Expose debug info
finnegancarroll Aug 1, 2024
9ab1447
Modify TreeTraversal usage to match new format
finnegancarroll Aug 1, 2024
5c713c6
In sub agg path collect by converted ordinal, not active index
finnegancarroll Aug 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix a bug
Signed-off-by: bowenlan-amzn <[email protected]>
bowenlan-amzn committed Jun 21, 2024
commit 6c097f3d3da1b5d9803d99c81298b7fc37a1073e
Original file line number Diff line number Diff line change
@@ -183,6 +183,7 @@ protected boolean canOptimize() {

// bucketOrds is used for saving the date histogram results got from the optimization path
bucketOrds = LongKeyedBucketOrds.build(context.bigArrays(), CardinalityUpperBound.ONE);
return true;
}
return false;
}