-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Star tree] Support for keyword changes as part of star tree mapper #16103
[Star tree] Support for keyword changes as part of star tree mapper #16103
Conversation
❌ Gradle check result for 249fa53: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
249fa53
to
49dd2f5
Compare
❌ Gradle check result for 49dd2f5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/internalClusterTest/java/org/opensearch/index/mapper/StarTreeMapperIT.java
Show resolved
Hide resolved
...c/main/java/org/opensearch/index/codec/composite/composite99/Composite99DocValuesWriter.java
Outdated
Show resolved
Hide resolved
49dd2f5
to
5d1414e
Compare
❌ Gradle check result for bc6fe9b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for e795925: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16103 +/- ##
============================================
+ Coverage 71.96% 72.08% +0.12%
- Complexity 64791 64838 +47
============================================
Files 5307 5308 +1
Lines 302714 302736 +22
Branches 43733 43732 -1
============================================
+ Hits 217836 218219 +383
+ Misses 67013 66632 -381
- Partials 17865 17885 +20 ☔ View full report in Codecov by Sentry. |
e795925
to
04989eb
Compare
❌ Gradle check result for 04989eb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
04989eb
to
dfdbdfc
Compare
❌ Gradle check result for dfdbdfc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Thanks @bharath-techie, LGTM! |
dfdbdfc
to
3f9a6f3
Compare
❌ Gradle check result for 3f9a6f3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Bharathwaj G <[email protected]>
Signed-off-by: Bharathwaj G <[email protected]>
3f9a6f3
to
a6a2418
Compare
❕ Gradle check result for a6a2418: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Description
This PR supports keyword fields as part of the star tree mapping.
This is built on top of date mapping PR.
As part of "ordered_dimensions" as part of star tree mapping , users can provide keyword fields as well now. [ Metrics are not supported for keyword, its still "numeric-only" supported for star tree]
Related Issues
Resolves #16232
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.