Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Star tree] Support for keyword changes as part of star tree mapper #16103

Closed

Conversation

bharath-techie
Copy link
Contributor

@bharath-techie bharath-techie commented Sep 27, 2024

Description

This PR supports keyword fields as part of the star tree mapping.

This is built on top of date mapping PR.

As part of "ordered_dimensions" as part of star tree mapping , users can provide keyword fields as well now. [ Metrics are not supported for keyword, its still "numeric-only" supported for star tree]

Related Issues

Resolves #16232

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 249fa53: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 3, 2024

❌ Gradle check result for 49dd2f5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 8, 2024

❌ Gradle check result for bc6fe9b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Indexing:Performance labels Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

❕ Gradle check result for e795925: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.08%. Comparing base (dc8a435) to head (a6a2418).
Report is 75 commits behind head on main.

Files with missing lines Patch % Lines
...ndex/compositeindex/datacube/DimensionFactory.java 66.66% 2 Missing and 1 partial ⚠️
...ndex/compositeindex/datacube/KeywordDimension.java 83.33% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16103      +/-   ##
============================================
+ Coverage     71.96%   72.08%   +0.12%     
- Complexity    64791    64838      +47     
============================================
  Files          5307     5308       +1     
  Lines        302714   302736      +22     
  Branches      43733    43732       -1     
============================================
+ Hits         217836   218219     +383     
+ Misses        67013    66632     -381     
- Partials      17865    17885      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Gradle check result for 04989eb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 04989eb: SUCCESS

Copy link
Contributor

❌ Gradle check result for dfdbdfc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sarthakaggarwal97
Copy link
Contributor

Thanks @bharath-techie, LGTM!

Copy link
Contributor

❌ Gradle check result for 3f9a6f3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Bharathwaj G <[email protected]>
Signed-off-by: Bharathwaj G <[email protected]>
Copy link
Contributor

❕ Gradle check result for a6a2418: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Indexing:Performance skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support for keyword fields as part of star tree index mapping
2 participants