[Snapshot v2] Run queued operations post v2 operations completion #16179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Bafna <[email protected]>
|
❕ Gradle check result for ebdf154: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16179 +/- ##
============================================
+ Coverage 71.88% 71.91% +0.02%
- Complexity 64496 64520 +24
============================================
Files 5291 5291
Lines 301668 301670 +2
Branches 43576 43576
============================================
+ Hits 216863 216950 +87
+ Misses 67031 66914 -117
- Partials 17774 17806 +32 ☔ View full report in Codecov by Sentry. |
gbbafna
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
sachinpkale
approved these changes
Oct 4, 2024
|
Changes are covered as part of integ tests which is not considered in CodeCov. Bypassing the check. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
Signed-off-by: Gaurav Bafna <[email protected]> (cherry picked from commit ba8f1be) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashking94
reviewed
Oct 7, 2024
| if (clusterService.state().nodes().isLocalNodeElectedClusterManager() == false) { | ||
| leaveRepoLoop(repositoryName); |
There was a problem hiding this comment.
Why have we moved this inside?
gbbafna
added a commit
that referenced
this pull request
Oct 7, 2024
… completion (#16191) * Run queued operations post v2 operations completion (#16179) Signed-off-by: Gaurav Bafna <[email protected]> (cherry picked from commit ba8f1be) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Mute snapshot v2 flaky tests (#16193) Signed-off-by: Gaurav Bafna <[email protected]> --------- Signed-off-by: Gaurav Bafna <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Gaurav Bafna <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…ct#16179) Signed-off-by: Gaurav Bafna <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…ct#16179) Signed-off-by: Gaurav Bafna <[email protected]>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…ct#16179) Signed-off-by: Gaurav Bafna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For snapshot-v2, we don't allow concurrent snapshots . But meanwhile non-v2 snapshot operations (clone / delete) can get queued . This is triggering the queued v1 operations.
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.