-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting Range over Star-Tree File Formats #16189
base: main
Are you sure you want to change the base?
Supporting Range over Star-Tree File Formats #16189
Conversation
Signed-off-by: Sarthak Aggarwal <[email protected]>
❌ Gradle check result for ed619e9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
* @throws IOException If there's an error reading from the input | ||
*/ | ||
private FixedLengthStarTreeNode binarySearchChild(long dimensionValue) throws IOException { | ||
public Iterator<FixedLengthStarTreeNode> range(long startDimensionValue, long endDimensionValue) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, we need to support list of ranges, with base case being just one range. Lets probably see if we can have a Range class similar to the one in RangeAggregator.
This PR is stalled because it has been open for 30 days with no activity. |
@sarthakaggarwal97 will you be taking this to closure? |
@sandeshkr419 waiting on @expani's changes on query side to check what's required. We'll need tighter integration involving changes in query interfaces all the way to file formats, so we'll either ways pick it up in another PR |
Description
This change supports range over the children over star-tree file formats.
Related Issues
Resolves #16190
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.