-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrieve value from DocValues in a flat_object filed #16802
base: main
Are you sure you want to change the base?
Conversation
❌ Gradle check result for 31a060d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
31a060d
to
6054295
Compare
❌ Gradle check result for 6054295: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
6054295
to
5f51b30
Compare
@kkewwei -- I plan to review this PR this week. (Lots of meetings this week, but should have time Thursday or Friday.) Please @ me or bug me on OpenSearch Slack if I don't! |
Thank you very much, some of the unit tests are not ready, I will fix soon and at you when all is ready. |
5f51b30
to
218a8bb
Compare
❌ Gradle check result for 54cd837: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
4523b74
to
a41d71e
Compare
SearchTimeoutIT.testSimpleTimeout #16056 |
TBR. |
❕ Gradle check result for a41d71e: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16802 +/- ##
============================================
+ Coverage 72.19% 72.26% +0.06%
- Complexity 65208 65253 +45
============================================
Files 5297 5297
Lines 303324 303347 +23
Branches 43913 43918 +5
============================================
+ Hits 218999 219200 +201
+ Misses 66367 66170 -197
- Partials 17958 17977 +19 ☔ View full report in Codecov by Sentry. |
SearchRestCancellationIT.testAutomaticCancellationDuringFetchPhase #14311 |
@msfroh please have a look when you are free. |
❌ Gradle check result for 5714d79: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/mapper/FlatObjectFieldMapper.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/mapper/FlatObjectFieldMapper.java
Outdated
Show resolved
Hide resolved
5714d79
to
d4cd439
Compare
❌ Gradle check result for d4cd439: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
d4cd439
to
237fce1
Compare
❌ Gradle check result for 237fce1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: kkewwei <[email protected]> Signed-off-by: kkewwei <[email protected]>
237fce1
to
cf49717
Compare
@msfroh, please help to merge the pr when you are free. |
Description
Added ability to retrieve value from DocValues in a flat_object filed
Related Issues
Resolves #16742
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.