Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve value from DocValues in a flat_object filed #16802

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Dec 8, 2024

Description

Added ability to retrieve value from DocValues in a flat_object filed

Related Issues

Resolves #16742

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing Storage:Performance labels Dec 8, 2024
Copy link
Contributor

github-actions bot commented Dec 8, 2024

❌ Gradle check result for 31a060d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the float_object_doc_value branch from 31a060d to 6054295 Compare December 8, 2024 20:57
Copy link
Contributor

github-actions bot commented Dec 8, 2024

❌ Gradle check result for 6054295: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the float_object_doc_value branch from 6054295 to 5f51b30 Compare December 9, 2024 03:07
@msfroh
Copy link
Collaborator

msfroh commented Dec 11, 2024

@kkewwei -- I plan to review this PR this week. (Lots of meetings this week, but should have time Thursday or Friday.) Please @ me or bug me on OpenSearch Slack if I don't!

@kkewwei
Copy link
Contributor Author

kkewwei commented Dec 11, 2024

@kkewwei -- I plan to review this PR this week. (Lots of meetings this week, but should have time Thursday or Friday.) Please @ me or bug me on OpenSearch Slack if I don't!

Thank you very much, some of the unit tests are not ready, I will fix soon and at you when all is ready.

@kkewwei kkewwei force-pushed the float_object_doc_value branch from 5f51b30 to 218a8bb Compare December 11, 2024 12:16
Copy link
Contributor

❌ Gradle check result for 54cd837: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the float_object_doc_value branch 3 times, most recently from 4523b74 to a41d71e Compare December 11, 2024 14:04
@kkewwei
Copy link
Contributor Author

kkewwei commented Dec 11, 2024

❌ Gradle check result for 54cd837: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

SearchTimeoutIT.testSimpleTimeout #16056

@kkewwei
Copy link
Contributor Author

kkewwei commented Dec 11, 2024

@kkewwei -- I plan to review this PR this week. (Lots of meetings this week, but should have time Thursday or Friday.) Please @ me or bug me on OpenSearch Slack if I don't!

Thank you very much, some of the unit tests are not ready, I will fix soon and at you when all is ready.

TBR.

Copy link
Contributor

❕ Gradle check result for a41d71e: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.26%. Comparing base (7050ecf) to head (cf49717).

Files with missing lines Patch % Lines
...opensearch/index/mapper/FlatObjectFieldMapper.java 54.54% 7 Missing and 3 partials ⚠️
...a/org/opensearch/index/mapper/DocValueFetcher.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16802      +/-   ##
============================================
+ Coverage     72.19%   72.26%   +0.06%     
- Complexity    65208    65253      +45     
============================================
  Files          5297     5297              
  Lines        303324   303347      +23     
  Branches      43913    43918       +5     
============================================
+ Hits         218999   219200     +201     
+ Misses        66367    66170     -197     
- Partials      17958    17977      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kkewwei
Copy link
Contributor Author

kkewwei commented Dec 12, 2024

❕ Gradle check result for a41d71e: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

SearchRestCancellationIT.testAutomaticCancellationDuringFetchPhase #14311

@kkewwei
Copy link
Contributor Author

kkewwei commented Dec 16, 2024

OpenSearch

@msfroh please have a look when you are free.

Copy link
Contributor

❌ Gradle check result for 5714d79: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the float_object_doc_value branch from 5714d79 to d4cd439 Compare December 18, 2024 04:01
Copy link
Contributor

❌ Gradle check result for d4cd439: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 237fce1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the float_object_doc_value branch from 237fce1 to cf49717 Compare December 20, 2024 09:05
Copy link
Contributor

✅ Gradle check result for cf49717: SUCCESS

@msfroh msfroh added the backport 2.x Backport to 2.x branch label Dec 21, 2024
@kkewwei
Copy link
Contributor Author

kkewwei commented Dec 27, 2024

@msfroh, please help to merge the pr when you are free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing Storage:Performance
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

[Feature Request] Retrieve value from DocValues in a flat_object filed
2 participants