Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pull-based Ingestion] use ConfigurationUtil for KafkaSourceConfig #17223

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yupeng9
Copy link
Contributor

@yupeng9 yupeng9 commented Feb 1, 2025

Description

  • Inspired by the ConfigurationUtil in the ingest package, introduce a ConfigurationUtil to the common util (and later can consolidate with the one in ingest package).

  • used this configurationUtil for configuration parsing in KafkaSourceConfig

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Feb 2, 2025

✅ Gradle check result for e8dceec: SUCCESS

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 83.07692% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.39%. Comparing base (6fb0c1b) to head (e8dceec).

Files with missing lines Patch % Lines
...a/org/opensearch/core/util/ConfigurationUtils.java 81.96% 5 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17223      +/-   ##
============================================
+ Coverage     72.24%   72.39%   +0.14%     
- Complexity    65704    65780      +76     
============================================
  Files          5318     5319       +1     
  Lines        305674   305735      +61     
  Branches      44349    44360      +11     
============================================
+ Hits         220834   221333     +499     
+ Misses        66769    66289     -480     
- Partials      18071    18113      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yupeng Fu <[email protected]>
Copy link
Contributor

github-actions bot commented Feb 2, 2025

❌ Gradle check result for 9751caf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

*
* @opensearch.internal
*/
public class ConfigurationUtils {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not reuse/extend the Settings specific classes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants