[Feature Request] Add support for a ForkJoinPool type #19008

srikanthpadakanti · 2025-08-10T00:31:02Z

Description

This PR adds support for a new ForkJoinPoolType to the ThreadPool object in OpenSearch. This enhancement enables registration and management of ForkJoinPool thread pools within the OpenSearch cluster lifecycle, which is particularly useful for components like jVector that utilize ForkJoinPool for faster index buildup.

Related Issues

Resolves #18674

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Srikanth Padakanti <[email protected]>

… entry Signed-off-by: Srikanth Padakanti <[email protected]>

github-actions · 2025-08-10T00:38:11Z

❌ Gradle check result for ddf3d9d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Srikanth Padakanti <[email protected]>

github-actions · 2025-08-10T02:29:23Z

❌ Gradle check result for e8e2e83: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Srikanth Padakanti <[email protected]>

github-actions · 2025-08-10T08:35:23Z

❌ Gradle check result for f96fd0e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Srikanth Padakanti <[email protected]>

github-actions · 2025-08-10T09:46:20Z

❌ Gradle check result for 5df90f6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Srikanth Padakanti <[email protected]>

github-actions · 2025-08-11T01:39:45Z

❌ Gradle check result for 30024e3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Srikanth Padakanti <[email protected]>

github-actions · 2025-08-11T02:54:08Z

❌ Gradle check result for 71e254c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Srikanth Padakanti <[email protected]>

github-actions · 2025-08-11T15:46:54Z

❌ Gradle check result for c73c4d5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Srikanth Padakanti <[email protected]>

github-actions · 2025-08-11T17:22:03Z

❌ Gradle check result for c4781ba: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

andrross · 2025-10-15T22:30:11Z

@karenyrx Can you take a final pass on this PR?

github-actions · 2025-10-15T22:48:11Z

✅ Gradle check result for efcafd1: SUCCESS

Signed-off-by: Srikanth Padakanti <[email protected]>

github-actions · 2025-10-16T00:01:37Z

❌ Gradle check result for 2238404: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Srikanth Padakanti <[email protected]>

github-actions · 2025-10-16T05:06:00Z

✅ Gradle check result for c9762f5: SUCCESS

...ins/test-forkjoinpool/src/main/java/org/opensearch/plugin/threadpool/ForkJoinPoolPlugin.java

…n registration Signed-off-by: Srikanth Padakanti <[email protected]>

github-actions · 2025-10-16T19:46:41Z

❕ Gradle check result for 1d64dba: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

…n registration Signed-off-by: Srikanth Padakanti <[email protected]>

github-actions · 2025-10-16T21:34:35Z

✅ Gradle check result for ca3f389: SUCCESS

Signed-off-by: Srikanth Padakanti <[email protected]>

github-actions · 2025-10-17T02:39:33Z

❌ Gradle check result for 22a1086: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

srikanthpadakanti · 2025-10-17T02:42:31Z

I wrote the testStatsAndValidateSettingForForkJoinPool to cover Stats method and validate setting, but the code coverage report still shows that part of the code is not covered.
I ran the same on local and I see this - attached the screenshots.

Signed-off-by: Srikanth Padakanti <[email protected]>

github-actions · 2025-10-17T04:16:44Z

❌ Gradle check result for 0511a4a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

srikanthpadakanti · 2025-10-17T04:51:06Z

@mch2 Failed test is unrelated to my change.

github-actions · 2025-10-17T17:13:26Z

✅ Gradle check result for 0511a4a: SUCCESS

…ject#19008) * Initial chekpoint Feature Request - Add support for a ForkJoinPool type Signed-off-by: Srikanth Padakanti <[email protected]> * [Feature Request] Add support for a ForkJoinPool type - Add changelog entry Signed-off-by: Srikanth Padakanti <[email protected]> * [Feature Request] Add support for a ForkJoinPool type - Add changelog entry Signed-off-by: Srikanth Padakanti <[email protected]> * Add support for a ForkJoinPool type - spotlessApply Signed-off-by: Srikanth Padakanti <[email protected]> * Initial chekpoint Feature Request - Add support for a ForkJoinPool type Signed-off-by: Srikanth Padakanti <[email protected]> * Initial chekpoint Feature Request - Add support for a ForkJoinPool type Signed-off-by: Srikanth Padakanti <[email protected]> * Initial chekpoint Feature Request - Add support for a ForkJoinPool type Signed-off-by: Srikanth Padakanti <[email protected]> * Initial chekpoint Feature Request - Add support for a ForkJoinPool type Signed-off-by: Srikanth Padakanti <[email protected]> * Initial chekpoint Feature Request - Add support for a ForkJoinPool type Signed-off-by: Srikanth Padakanti <[email protected]> * Initial chekpoint Feature Request - Add support for a ForkJoinPool type Signed-off-by: Srikanth Padakanti <[email protected]> * Initial chekpoint Feature Request - Add support for a ForkJoinPool type Signed-off-by: Srikanth Padakanti <[email protected]> * Initial chekpoint Feature Request - Add support for a ForkJoinPool type Signed-off-by: Srikanth Padakanti <[email protected]> * Initial chekpoint Feature Request - Add support for a ForkJoinPool type Signed-off-by: Srikanth Padakanti <[email protected]> * Initial chekpoint Feature Request - Add support for a ForkJoinPool type Signed-off-by: Srikanth Padakanti <[email protected]> * Initial chekpoint Feature Request - Add support for a ForkJoinPool type Signed-off-by: Srikanth Padakanti <[email protected]> * Add few more tests to cover the code Signed-off-by: Srikanth Padakanti <[email protected]> * Add few more tests to cover the code Signed-off-by: Srikanth Padakanti <[email protected]> * Backward Compatibility : fallback to FIXED for unknown types Signed-off-by: Srikanth Padakanti <[email protected]> * Backward Compatibility : fallback to FIXED for unknown types Signed-off-by: Srikanth Padakanti <[email protected]> * Backward Compatibility : fallback to FIXED for unknown types Signed-off-by: Srikanth Padakanti <[email protected]> * Backward Compatibility : fallback to FIXED for unknown types Signed-off-by: Srikanth Padakanti <[email protected]> * Addressed the PR comments Signed-off-by: Srikanth Padakanti <[email protected]> * Apply spotlesscheck Signed-off-by: Srikanth Padakanti <[email protected]> * Apply spotlesscheck and merge new changes to my main branch Signed-off-by: Srikanth Padakanti <[email protected]> * Remove the allowlist and the registration method. Signed-off-by: Srikanth Padakanti <[email protected]> * Address the PR comments for the awaitTermination in threadpool Signed-off-by: Srikanth Padakanti <[email protected]> * Address the PR comments for the awaitTermination in threadpool Signed-off-by: Srikanth Padakanti <[email protected]> * Addressed the PR comments Signed-off-by: Srikanth Padakanti <[email protected]> * Address the PR comments Signed-off-by: Srikanth Padakanti <[email protected]> * Address the PR comments Signed-off-by: Srikanth Padakanti <[email protected]> * Address the PR comments Signed-off-by: Srikanth Padakanti <[email protected]> * Address the PR comments Signed-off-by: Srikanth Padakanti <[email protected]> * Address the PR comments Signed-off-by: Srikanth Padakanti <[email protected]> * Address the PR comments Signed-off-by: Srikanth Padakanti <[email protected]> * Address the PR comments for Yaml tests Signed-off-by: Srikanth Padakanti <[email protected]> * Address the PR comments for Yaml tests Signed-off-by: Srikanth Padakanti <[email protected]> * Address the PR comments for Yaml tests Signed-off-by: Srikanth Padakanti <[email protected]> * Address the PR comments for Yaml tests Signed-off-by: Srikanth Padakanti <[email protected]> * Address the PR comments for Yaml tests Signed-off-by: Srikanth Padakanti <[email protected]> * Address the PR comments for Yaml tests Signed-off-by: Srikanth Padakanti <[email protected]> * Address the PR comments for Yaml tests Signed-off-by: Srikanth Padakanti <[email protected]> * Address the PR comments for Yaml tests Signed-off-by: Srikanth Padakanti <[email protected]> * Address the PR comments for Yaml tests Signed-off-by: Srikanth Padakanti <[email protected]> * Address the PR comments for Yaml tests Signed-off-by: Srikanth Padakanti <[email protected]> * Address the PR comments for Yaml tests Signed-off-by: Srikanth Padakanti <[email protected]> * Address code review comments Signed-off-by: Srikanth Padakanti <[email protected]> * Address code review comments Signed-off-by: Srikanth Padakanti <[email protected]> * Address code review comments Signed-off-by: Srikanth Padakanti <[email protected]> * Address code review comments Signed-off-by: Srikanth Padakanti <[email protected]> * Address code review comments Signed-off-by: Srikanth Padakanti <[email protected]> * Address code review comments Signed-off-by: Srikanth Padakanti <[email protected]> * Resolve merge conflicts Signed-off-by: Srikanth Padakanti <[email protected]> * Introduce new settings in ForkJoinPoolExecutorBuilder Signed-off-by: Srikanth Padakanti <[email protected]> * overload the constructor and keep the existing version for compatibility. Signed-off-by: Srikanth Padakanti <[email protected]> * Fix the precommit failure issues Signed-off-by: Srikanth Padakanti <[email protected]> * Fix the test failures for queue size Signed-off-by: Srikanth Padakanti <[email protected]> * Fix the test failures for queue size Signed-off-by: Srikanth Padakanti <[email protected]> * Added tests Signed-off-by: Srikanth Padakanti <[email protected]> * Added tests for the codecoverage target Signed-off-by: Srikanth Padakanti <[email protected]> * Changed te scope of buildTable and removed reflection Signed-off-by: Srikanth Padakanti <[email protected]> * Changed te scope of buildTable and removed reflection Signed-off-by: Srikanth Padakanti <[email protected]> * Changed the IT from plugin folder to single node IT with inline plugin registration Signed-off-by: Srikanth Padakanti <[email protected]> * Changed the IT from plugin folder to single node IT with inline plugin registration Signed-off-by: Srikanth Padakanti <[email protected]> * Changed the IT from plugin folder to single node IT with inline plugin registration Signed-off-by: Srikanth Padakanti <[email protected]> * Removed the build.gradle dependency opensearch-common Signed-off-by: Srikanth Padakanti <[email protected]> * Removed the build.gradle dependency opensearch-common Signed-off-by: Srikanth Padakanti <[email protected]> --------- Signed-off-by: Srikanth Padakanti <[email protected]> Signed-off-by: Srikanth Padakanti <[email protected]> Co-authored-by: Srikanth Padakanti <[email protected]>

Srikanth Padakanti and others added 5 commits August 6, 2025 02:24

Initial chekpoint Feature Request - Add support for a ForkJoinPool type

c753c31

Signed-off-by: Srikanth Padakanti <[email protected]>

Merge upstream/main and FeatureRequest18674

7589b39

Signed-off-by: Srikanth Padakanti <[email protected]>

Merge branch 'opensearch-project:main' into main

4463d5a

Merge branch 'opensearch-project:main' into main

e287c6f

[Feature Request] Add support for a ForkJoinPool type - Add changelog…

875221e

… entry Signed-off-by: Srikanth Padakanti <[email protected]>

github-actions bot added enhancement Enhancement or improvement to existing feature or request Other labels Aug 10, 2025

[Feature Request] Add support for a ForkJoinPool type - Add changelog…

ddf3d9d

… entry Signed-off-by: Srikanth Padakanti <[email protected]>

Add support for a ForkJoinPool type - spotlessApply

e8e2e83

Signed-off-by: Srikanth Padakanti <[email protected]>

Initial chekpoint Feature Request - Add support for a ForkJoinPool type

f96fd0e

Signed-off-by: Srikanth Padakanti <[email protected]>

Initial chekpoint Feature Request - Add support for a ForkJoinPool type

5df90f6

Signed-off-by: Srikanth Padakanti <[email protected]>

Srikanth Padakanti added 2 commits August 10, 2025 19:52

Initial chekpoint Feature Request - Add support for a ForkJoinPool type

0d508b6

Signed-off-by: Srikanth Padakanti <[email protected]>

Initial chekpoint Feature Request - Add support for a ForkJoinPool type

30024e3

Signed-off-by: Srikanth Padakanti <[email protected]>

Initial chekpoint Feature Request - Add support for a ForkJoinPool type

71e254c

Signed-off-by: Srikanth Padakanti <[email protected]>

Initial chekpoint Feature Request - Add support for a ForkJoinPool type

c73c4d5

Signed-off-by: Srikanth Padakanti <[email protected]>

Srikanth Padakanti added 4 commits August 11, 2025 11:15

Initial chekpoint Feature Request - Add support for a ForkJoinPool type

cb433f8

Signed-off-by: Srikanth Padakanti <[email protected]>

Initial chekpoint Feature Request - Add support for a ForkJoinPool type

c1fa79c

Signed-off-by: Srikanth Padakanti <[email protected]>

Initial chekpoint Feature Request - Add support for a ForkJoinPool type

71aaad9

Signed-off-by: Srikanth Padakanti <[email protected]>

Initial chekpoint Feature Request - Add support for a ForkJoinPool type

c4781ba

Signed-off-by: Srikanth Padakanti <[email protected]>

andrross approved these changes Oct 15, 2025

View reviewed changes

srikanthpadakanti requested a review from mch2 October 15, 2025 22:49

Added tests for the codecoverage target

2238404

Signed-off-by: Srikanth Padakanti <[email protected]>

Srikanth Padakanti added 2 commits October 15, 2025 22:14

Changed te scope of buildTable and removed reflection

6d5db6f

Signed-off-by: Srikanth Padakanti <[email protected]>

Changed te scope of buildTable and removed reflection

c9762f5

Signed-off-by: Srikanth Padakanti <[email protected]>

mch2 requested changes Oct 16, 2025

View reviewed changes

...ins/test-forkjoinpool/src/main/java/org/opensearch/plugin/threadpool/ForkJoinPoolPlugin.java Outdated Show resolved Hide resolved

mch2 reviewed Oct 16, 2025

View reviewed changes

...ins/test-forkjoinpool/src/main/java/org/opensearch/plugin/threadpool/ForkJoinPoolPlugin.java Outdated Show resolved Hide resolved

srikanthpadakanti and others added 3 commits October 16, 2025 13:04

Merge branch 'opensearch-project:main' into main

9e52fcd

Changed the IT from plugin folder to single node IT with inline plugi…

5f55cd9

…n registration Signed-off-by: Srikanth Padakanti <[email protected]>

Changed the IT from plugin folder to single node IT with inline plugi…

1d64dba

…n registration Signed-off-by: Srikanth Padakanti <[email protected]>

srikanthpadakanti and others added 2 commits October 16, 2025 14:54

Merge branch 'opensearch-project:main' into main

ab0a165

Changed the IT from plugin folder to single node IT with inline plugi…

ca3f389

…n registration Signed-off-by: Srikanth Padakanti <[email protected]>

srikanthpadakanti and others added 2 commits October 16, 2025 20:46

Merge branch 'opensearch-project:main' into main

f0ef745

Removed the build.gradle dependency opensearch-common

22a1086

Signed-off-by: Srikanth Padakanti <[email protected]>

Removed the build.gradle dependency opensearch-common

0511a4a

Signed-off-by: Srikanth Padakanti <[email protected]>

opensearch-ci-bot mentioned this pull request Oct 17, 2025

[AUTOCUT] Gradle Check Flaky Test Report for FullClusterRestartIT #15813

Open

mch2 approved these changes Oct 17, 2025

View reviewed changes

mch2 merged commit 7042e77 into opensearch-project:main Oct 17, 2025
34 of 36 checks passed

[Feature Request] Add support for a ForkJoinPool type #19008

[Feature Request] Add support for a ForkJoinPool type #19008

Conversation

srikanthpadakanti commented Aug 10, 2025

Description

Related Issues

Check List

Uh oh!

github-actions bot commented Aug 10, 2025

Uh oh!

github-actions bot commented Aug 10, 2025

Uh oh!

github-actions bot commented Aug 10, 2025

Uh oh!

github-actions bot commented Aug 10, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 11, 2025

Uh oh!

andrross commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

srikanthpadakanti commented Oct 17, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

srikanthpadakanti commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

srikanthpadakanti commented Oct 17, 2025 •

edited

Loading