-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace non-inclusive terminology 'master' in code comments and internal variable/method/class names #2150
Closed
+805
−759
Closed
Replace non-inclusive terminology 'master' in code comments and internal variable/method/class names #2150
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
45ee23d
Replace master in NoMasterBlockService class
b597d96
Replace master in Coordinator class
e71406e
Replace master in ClusterHealthResponse class
541ce80
Replace master in Method withMasterTimeout()
7679794
Replace master in TimedRequest class
c80b14f
Replace master in Method get/setMasterTimeout()
f1a63ef
Replace master of method SetRandomMasterTimeout()
998e88d
Replace master in subprojects - client modules plugins qa
50f0de0
Replace master in TestCluster classes
cbc71a2
Replace master in test.framework test classes
9835546
Replace master terminology in classes of server directories
9b4719b
adjust format by spotlessApply
tlfeng b41fe3b
Replace master terminology in classes of server directories - leftover
tlfeng e2e9347
Replace master in server classes - leftover
1e42576
Adjust format by spotlessApply task
9026aed
Replace master in server test classes
63282ff
Merge remote-tracking branch 'upstream/main' into replace-master-inte…
8af6374
Adjust format by spotlessApply task
ce8c7e9
Adjust format by spotlessApply task
7e352ef
Change 'clustermanager' to 'cluster_manager' or 'cluster manager' in …
9d3b42f
Merge branch 'main' into replace-master-internal
d8b016d
Merge branch 'main' into replace-master-internal
tlfeng 91d768c
Rename initialMasterNodes
4f1211c
Merge remote-tracking branch 'origin/main' into replace-master-internal
717bc11
Rename clusterManagerNodeNames
36a5bbe
Merge branch 'main' into replace-master-internal
0817155
Merge branch 'main' into replace-master-internal
3c204eb
Restore rename DISCOVERED_MASTER in ClusterHealthResponse
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Replace master in TimedRequest class
Signed-off-by: Tianli Feng <[email protected]>
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might also want to update this variable name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review!
I think I'm not going to rename this variable name. It's a Java API which may break the compatibility to other software that uses
server
package: https://opensearch.org/javadocs/1.2.4/OpenSearch/server/build/docs/javadoc/org/opensearch/action/support/master/MasterNodeRequest.html#DEFAULT_MASTER_NODE_TIMEOUTThe current plan is to replace all those names in Java API directly in version 3.0.0 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay! Thank you :)