-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PrimaryShardBatchAllocator to take allocation decisions for a batch of shards #8916
Add PrimaryShardBatchAllocator to take allocation decisions for a batch of shards #8916
Conversation
…ch of shards Signed-off-by: Aman Khare <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
This PR is stalled because it has been open for 30 days with no activity. Remove stalled label or comment or this will be closed in 7 days. |
PR will be updated in few days. |
Signed-off-by: Aman Khare <[email protected]>
Compatibility status:Checks if related components are compatible with change d372c54 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git] |
❕ Gradle check result for 6112f4b: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8916 +/- ##
============================================
- Coverage 71.42% 71.37% -0.05%
- Complexity 59978 60087 +109
============================================
Files 4985 4993 +8
Lines 282275 282751 +476
Branches 40946 40998 +52
============================================
+ Hits 201603 201825 +222
- Misses 63999 64179 +180
- Partials 16673 16747 +74 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Aman Khare <[email protected]>
❌ Gradle check result for e798d7a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…ching Signed-off-by: Aman Khare <[email protected]>
❕ Gradle check result for f702715: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Flaky test : #12197 |
server/src/main/java/org/opensearch/gateway/TransportNodesGatewayStartedShardHelper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/gateway/TransportNodesGatewayStartedShardHelper.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Aman Khare <[email protected]>
❌ Gradle check result for d372c54: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test testConnectAndExecuteRequest #12338 |
❌ Gradle check result for d372c54: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test testDelayWithALargeAmountOfShards : #10558 |
a499d1e
into
opensearch-project:main
…ch of shards (#8916) * Add PrimaryShardBatchAllocator to take allocation decisions for a batch of shards Signed-off-by: Aman Khare <[email protected]> (cherry picked from commit a499d1e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ch of shards (#8916) * Add PrimaryShardBatchAllocator to take allocation decisions for a batch of shards Signed-off-by: Aman Khare <[email protected]> (cherry picked from commit a499d1e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ch of shards (#8916) (#12813) * Add PrimaryShardBatchAllocator to take allocation decisions for a batch of shards (cherry picked from commit a499d1e) Signed-off-by: Aman Khare <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ch of shards (#8916) (#12813) * Add PrimaryShardBatchAllocator to take allocation decisions for a batch of shards (cherry picked from commit a499d1e) Signed-off-by: Aman Khare <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit b2d22d4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ch of shards (#8916) (#12813) (#12823) * Add PrimaryShardBatchAllocator to take allocation decisions for a batch of shards (cherry picked from commit a499d1e) (cherry picked from commit b2d22d4) Signed-off-by: Aman Khare <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ch of shards (opensearch-project#8916) * Add PrimaryShardBatchAllocator to take allocation decisions for a batch of shards Signed-off-by: Aman Khare <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
This PR is a continuation of the project #5098
Meta Issue : #8098 (Also contains in which order this PR should be merged)
This PR can be reviewed after #9760
As part of node drop and joins, we fetch the metadata of unassigned shards on per shard basis.
OpenSearch/server/src/main/java/org/opensearch/gateway/AsyncShardFetch.java
Line 74 in c25c175
PrimaryShardAllocator can build allocation decision for a single unassigned shard. We need to add support for building decisions for a batch of shards, so adding new class for that.
Note :
Additional context
Please go through the discussion #5098 to understand the overall enhancement approach and check #8098 to see the sub tasks of overall project.
Related Issues
Resolves #8960
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.