[BugFix] AlertSummary still displays when agents required are not configured #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
000FLMS
requested review from
lezzago,
AWSHurneyt,
amsiglan,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
bowenlan-amzn,
rishabhmaurya and
riysaxen-amzn
as code owners
000FLMS
changed the title
000FLMS
changed the title
000FLMS
changed the title
songkant-aws
reviewed
Nov 4, 2024
Signed-off-by: Sihan He <[email protected]>
Signed-off-by: Sihan He <[email protected]>
Signed-off-by: Sihan He <[email protected]>
Signed-off-by: Sihan He <[email protected]>
Signed-off-by: Sihan He <[email protected]>
Signed-off-by: Sihan He <[email protected]>
Signed-off-by: Sihan He <[email protected]>
AWSHurneyt
approved these changes
Jan 21, 2025
riysaxen-amzn
approved these changes
Jan 21, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
…figured (#1142) * bug fix for agent configuration Signed-off-by: Sihan He <[email protected]> * remove redundant codes Signed-off-by: Sihan He <[email protected]> * remove logs Signed-off-by: Sihan He <[email protected]> * handle exceptions Signed-off-by: Sihan He <[email protected]> * set default agentClient Signed-off-by: Sihan He <[email protected]> * update test Signed-off-by: Sihan He <[email protected]> * add error message Signed-off-by: Sihan He <[email protected]> --------- Signed-off-by: Sihan He <[email protected]> (cherry picked from commit 9a90b8f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bug fix for alertSummary still displays when agents required are not configured in the selected datasource.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Screenshots
data source with required agents configured
data source without agents
