API to enable/disable a monitor #1771
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikhy-aws
requested review from
lezzago,
AWSHurneyt,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
bowenlan-amzn,
rishabhmaurya,
engechas,
riysaxen-amzn,
jowg-amazon,
amsiglan and
goyamegh
as code owners
Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: vikhy-aws <[email protected]>
| return mutableListOf( | ||
| ReplacedRoute( | ||
| PUT, | ||
| "${AlertingPlugin.MONITOR_BASE_URI}/{monitorID}/_enable", |
There was a problem hiding this comment.
What security level perms are we giving to these APIs, we need to make changes in Security plugin for that, check this -> https://github.com/opensearch-project/security/blob/a1ccbd56621609d1ae0b0f7b4780b968ed06024b/config/roles.yml#L32
AWSHurneyt
reviewed
Jan 25, 2025
alerting/src/main/kotlin/org/opensearch/alerting/resthandler/RestToggleMonitorAction.kt
Outdated
Show resolved
Hide resolved
alerting/src/main/kotlin/org/opensearch/alerting/resthandler/RestToggleMonitorAction.kt
Outdated
Show resolved
Hide resolved
alerting/src/main/kotlin/org/opensearch/alerting/resthandler/RestToggleMonitorAction.kt
Show resolved
Hide resolved
| try { | ||
| if (getMonitorResponse.monitor == null) { | ||
| actionListener.onFailure( | ||
| OpenSearchStatusException("Monitor $monitorId not found", RestStatus.NOT_FOUND) |
There was a problem hiding this comment.
Small observation. As a best practice, we should end error messages with periods (.).
…ding to comments on PR Signed-off-by: vikhy-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds request and response classes to common-utils to create an API that enables or disables the monitor using the following:
Related Issues
Resolves #1058
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.