Wait on AsynchronousSearchStatsRequest before asserting on statsResponse #617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
testStatsAcrossNodes is flaky and I suspect this is because we do not wait on the result of
AsynchronousSearchStatsRequest
before asserting that node stats equal their expected values. Integration tests fail with this error and while a stack trace is not available it's suspiciously similar to the failure we see when we artificially ensurestatsResponse
is empty.NOTE: I was NOT able to reproduce this test failure to confirm the fix.
Related Issues
Speculative fix for #87
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.